FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(TextArea): Add a prop to allow limiting the resize orientation o… by tlabaj · Pull Request #3180 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(TextArea): Add a prop to allow limiting the resize orientation o… - #3180

Merged
dlabaj merged 2 commits into
patternfly:masterfrom
tlabaj:textarea_resize
Oct 24, 2019
ConversationCommits (2)ChecksFiles changed
Merged

feat(TextArea): Add a prop to allow limiting the resize orientation o…#3180
dlabaj merged 2 commits into
patternfly:masterfrom
tlabaj:textarea_resize

Conversation

tlabaj commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

…f the TextAres

#2839

What:

Additional issues:

patternfly-build commented Oct 22, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3180.surge.sh

patternfly-build commented Oct 22, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3180.surge.sh

codecov-io commented Oct 22, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3180 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
+ Coverage   68.99%   68.99%   +<.01%     
==========================================
  Files         858      858              
  Lines       23625    23633       +8     
  Branches     1892     1894       +2     
==========================================
+ Hits        16300    16306       +6     
  Misses       6366     6366              
- Partials      959      961       +2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 67.96% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...-4/react-core/src/components/TextArea/TextArea.tsx 95.45% <100%> (+1.7%) ⬆️
...components/ClipboardCopy/ClipboardCopyExpanded.tsx 70.58% <0%> (-14.03%) ⬇️
...rnfly-4/react-core/src/components/withOuia/ouia.ts 66.66% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ee9f7...3f4a1b4. Read the comment docs.

christiemolloy approved these changes Oct 24, 2019
View reviewed changes

christiemolloy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

dlabaj approved these changes Oct 24, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good job.

dlabaj merged commit d61ae9d into patternfly:master Oct 24, 2019
tlabaj mentioned this pull request Oct 24, 2019
Closed

patternfly-build commented Oct 24, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.119.0
  • @patternfly/react-docs@4.15.8
  • @patternfly/react-inline-edit-extension@2.12.8
  • demo-app-ts@3.9.0
  • @patternfly/react-integration@3.9.0
  • @patternfly/react-table@2.24.8
  • @patternfly/react-topology@2.10.8
  • @patternfly/react-virtualized-extension@1.3.8

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
jessiehuff Awaiting requested review from jessiehuff
+1 more reviewer
christiemolloy christiemolloy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jessiehuff

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL