FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(table): add empty state and spinner to pagination table demo by boaz0 · Pull Request #3232 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

docs(table): add empty state and spinner to pagination table demo - #3232

Closed
boaz0 wants to merge 1 commit into
patternfly:masterfrom
boaz0:closes_3184
ConversationCommits (1)ChecksFiles changed
Closed

docs(table): add empty state and spinner to pagination table demo#3232
boaz0 wants to merge 1 commit into
patternfly:masterfrom
boaz0:closes_3184

Conversation

boaz0 commented Oct 29, 2019

Copy link
Copy Markdown
Member

What:

closes #3184

docs(table): add empty state and spinner to pagination table demo
b7e0cdd 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

codecov-io commented Oct 29, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3232 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3232   +/-   ##
=======================================
  Coverage   67.44%   67.44%           
=======================================
  Files         892      892           
  Lines       24872    24872           
  Branches     2142     2142           
=======================================
  Hits        16774    16774           
  Misses       7093     7093           
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377ac47...b7e0cdd. Read the comment docs.

patternfly-build commented Oct 29, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3232.surge.sh

tlabaj self-assigned this Nov 5, 2019
tlabaj requested a review from christiemolloy November 5, 2019 17:23
dlabrecq suggested changes Nov 5, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/demos/PaginationTable.md
page: 1,
error: null,
loading: true
loading: false

dlabrecq Nov 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not able to see the spinner. Thinking loading should be true initially?

Comment thread packages/patternfly-4/react-core/src/demos/PaginationTable.md
<EmptyStateIcon icon={TimesIcon} />
<Title size="lg">Failed to fetch data</Title>
</EmptyState>
</Bullseye>

dlabrecq Nov 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not able to see this empty state. How does the user see an empty state with this demo?

Perhaps we can add a toggle?

dlabrecq mentioned this pull request Nov 8, 2019
Merged

boaz0 commented Nov 11, 2019

Copy link
Copy Markdown
Member Author

closing this in favor of #3294

boaz0 closed this Nov 11, 2019
boaz0 deleted the closes_3184 branch November 11, 2019 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

christiemolloy Awaiting requested review from christiemolloy
1 more reviewer
dlabrecq dlabrecq requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

tlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: update PaginationToolbar demo to include spinner and error handling

5 participants

Back | FazBrowse Home | New Git URL