FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(wizard,aboutmodal): remove appendTo from props passed to div by boaz0 · Pull Request #3239 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(wizard,aboutmodal): remove appendTo from props passed to div - #3239

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3237
Nov 18, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(wizard,aboutmodal): remove appendTo from props passed to div#3239
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3237

Conversation

boaz0 commented Oct 30, 2019

Copy link
Copy Markdown
Member

What:

closes #3237

//cc @keithjgrant

fix(wizard,aboutmodal): remove appendTo from props passed to div
9bcc062 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
tlabaj requested review from dlabaj and jschuler November 5, 2019 17:42
dlabrecq approved these changes Nov 5, 2019
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Just need to kick off a new build. Perhaps that's something @redallen can do?

redallen commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

Rekicked.

patternfly-build commented Nov 7, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3239.surge.sh

codecov-io commented Nov 7, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3239 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3239      +/-   ##
==========================================
- Coverage   67.43%   67.43%   -0.01%     
==========================================
  Files         892      892              
  Lines       24874    24878       +4     
  Branches     2141     2141              
==========================================
+ Hits        16775    16776       +1     
- Misses       7094     7097       +3     
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.74% <100%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Wizard/Wizard.tsx 54.33% <100%> (+0.2%) ⬆️
...eact-core/src/components/AboutModal/AboutModal.tsx 85.24% <100%> (ø) ⬆️
...nfly-react/src/components/AboutModal/AboutModal.js 46.22% <0%> (-0.89%) ⬇️
...3/patternfly-react/src/components/Wizard/Wizard.js 32.95% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 269a6f0...9bcc062. Read the comment docs.

tlabaj approved these changes Nov 18, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 0b62699 into patternfly:master Nov 18, 2019

patternfly-build commented Nov 18, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.22
  • @patternfly/react-core@3.120.13
  • @patternfly/react-docs@4.16.27
  • @patternfly/react-inline-edit-extension@2.12.27
  • demo-app-ts@3.9.16
  • @patternfly/react-table@2.24.27
  • @patternfly/react-topology@2.11.13
  • @patternfly/react-virtualized-extension@1.3.26

Thanks for your contribution! 🎉

boaz0 deleted the closes_3237 branch November 19, 2019 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj Awaiting requested review from dlabaj
jschuler Awaiting requested review from jschuler
2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jschuler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF4 Wizard throws warning about 'appendTo' prop

7 participants

Back | FazBrowse Home | New Git URL