FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(button): support setting tab index unless not button and disabled by boaz0 · Pull Request #3240 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(button): support setting tab index unless not button and disabled - #3240

Merged
redallen merged 1 commit into
patternfly:masterfrom
boaz0:closes_3208
Nov 21, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(button): support setting tab index unless not button and disabled#3240
redallen merged 1 commit into
patternfly:masterfrom
boaz0:closes_3208

Conversation

boaz0 commented Oct 30, 2019

Copy link
Copy Markdown
Member

What:

closes #3208

//cc @petli-openshift

codecov-io commented Nov 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3240 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3240      +/-   ##
==========================================
+ Coverage   67.37%   67.37%   +<.01%     
==========================================
  Files         893      893              
  Lines       24957    24960       +3     
  Branches     2157     2158       +1     
==========================================
+ Hits        16815    16818       +3     
  Misses       7136     7136              
  Partials     1006     1006
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.67% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Button/Button.tsx 88.46% <100%> (+0.22%) ⬆️
...3/patternfly-react/src/components/Button/Button.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe604f3...7cf7490. Read the comment docs.

boaz0 commented Nov 4, 2019

Copy link
Copy Markdown
Member Author

It seems like a problem with the memory size causes pf4 docs build to fail.

In addition, I can build the docs successfully on my machine and can't reproduce it on my machine.

@redallen can you look at it?

@patternfly/react-docs: failed Building static HTML for pages - 70.042s
@patternfly/react-docs: error Building static HTML failed
@patternfly/react-docs: 1 | function _defineProperty(obj, key, value) {
@patternfly/react-docs: > 2 | if (key in obj) {
@patternfly/react-docs: | ^
@patternfly/react-docs: 3 | Object.defineProperty(obj, key, {
@patternfly/react-docs: 4 | value: value,
@patternfly/react-docs: 5 | enumerable: true,
@patternfly/react-docs:
@patternfly/react-docs: WebpackError: Call retries were exceeded

redallen commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

Yeah, this is an OOM error. I left both -next and -org previews somewhat broken last week and are going to go back and fix them this week. I've rekicked your job for you in the meantime.

patternfly-build commented Nov 4, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3240.surge.sh

boaz0 commented Nov 5, 2019

Copy link
Copy Markdown
Member Author

Thanks @redallen !

tlabaj suggested changes Nov 5, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you also add the tabIndex prop to the demo-app so we can verify the types.

tlabaj requested a review from kmcfaul November 5, 2019 17:38

tlabaj commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

@boaz0 Can you update this pR so we can try and get it in? Thanks!

boaz0 commented Nov 19, 2019

Copy link
Copy Markdown
Member Author

Yeah sure. No problem.

redallen previously approved these changes Nov 20, 2019
View reviewed changes
fix(button): support setting tab index unless not button and disabled
7cf7490 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
tlabaj approved these changes Nov 20, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen merged commit 759c8f1 into patternfly:master Nov 21, 2019

patternfly-build commented Nov 21, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.34
  • @patternfly/react-core@3.122.4
  • @patternfly/react-docs@4.16.40
  • @patternfly/react-inline-edit-extension@2.13.5
  • demo-app-ts@3.11.4
  • @patternfly/react-integration@3.11.1
  • @patternfly/react-table@2.24.37
  • @patternfly/react-topology@2.11.23
  • @patternfly/react-virtualized-extension@1.3.36

Thanks for your contribution! 🎉

boaz0 deleted the closes_3208 branch April 24, 2020 06:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kmcfaul Awaiting requested review from kmcfaul
2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jessiehuff

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF4 Button does not pass through tabIndex prop

6 participants

Back | FazBrowse Home | New Git URL