FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Charts: Interactive legend example by dlabrecq · Pull Request #3253 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Charts: Interactive legend example - #3253

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:2352-interactive-legend
Nov 19, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Charts: Interactive legend example#3253
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:2352-interactive-legend

Conversation

dlabrecq commented Nov 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

dlabrecq force-pushed the 2352-interactive-legend branch from f036983 to 23bef9f Compare November 1, 2019 16:22

codecov-io commented Nov 1, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3253 into master will decrease coverage by 0.11%.
The diff coverage is 12%.

@@            Coverage Diff             @@
##           master    #3253      +/-   ##
==========================================
- Coverage   67.44%   67.33%   -0.12%     
==========================================
  Files         892      893       +1     
  Lines       24867    24917      +50     
  Branches     2141     2150       +9     
==========================================
+ Hits        16772    16778       +6     
- Misses       7091     7135      +44     
  Partials     1004     1004
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.55% <12%> (-0.23%) ⬇️
Impacted Files Coverage Δ
...ct-charts/src/components/ChartPoint/ChartPoint.tsx 17.85% <ø> (ø) ⬆️
...t-charts/src/components/ChartPoint/path-helpers.ts 3.5% <0%> (-0.34%) ⬇️
...-4/react-charts/src/components/ChartUtils/index.ts 100% <100%> (ø) ⬆️
.../components/ChartUtils/chart-interactive-legend.ts 11.36% <11.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c1bbc...aade734. Read the comment docs.

dlabrecq force-pushed the 2352-interactive-legend branch from 23bef9f to 06ba2e7 Compare November 1, 2019 16:53
patternfly deleted a comment from patternfly-build Nov 1, 2019
tlabaj requested a review from mturley November 5, 2019 17:42
dlabrecq force-pushed the 2352-interactive-legend branch from 06ba2e7 to 683fcb8 Compare November 5, 2019 19:23

patternfly-build commented Nov 5, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3253.surge.sh

patternfly deleted a comment from patternfly-build Nov 5, 2019
tlabaj requested a review from dlabaj November 5, 2019 22:43
mturley reviewed Nov 6, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-charts/src/components/ChartLegend/examples/ChartLegend.md
}

// Tips:
// 1. Don't omit components unless using custom colors -- that will reassign color scale

mturley Nov 6, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should we move these Tips from the example source code to the Tips section of the markdown documentation below, so they appear without having to expand the code block? I'm not sure, since we do still want people reading this example code to make sure they scroll down to see the tips. If we do move them, maybe we can leave a comment here like // See the Tips section below for important notes about color scale, axis labels and tooltips.

dlabrecq Nov 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Possibly? The tips at the bottom apply to all examples, while this applies only to this particular example. Perhaps we just don't label this as "Tips" and just inline the comments?

mturley Nov 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, I didn't realize it was specific to this example. I could go either way then.

mturley approved these changes Nov 7, 2019
View reviewed changes

mturley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabrecq force-pushed the 2352-interactive-legend branch from 683fcb8 to aade734 Compare November 13, 2019 00:40

patternfly-build commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3253.surge.sh

mcarrano requested a review from mceledonia November 18, 2019 16:48

mcarrano commented Nov 18, 2019

Copy link
Copy Markdown
Member

@mceledonia can you review this to make sure the implementation is consistent with design intent?

tlabaj approved these changes Nov 19, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 018ff0c into patternfly:master Nov 19, 2019
dlabrecq deleted the 2352-interactive-legend branch January 15, 2020 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj Awaiting requested review from dlabaj
mceledonia Awaiting requested review from mceledonia
2 more reviewers
mturley mturley approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

redallen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Charts: interactive legend

7 participants

Back | FazBrowse Home | New Git URL