FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PF4: fix(README.md): provides URL location of workspace by jenny-s51 · Pull Request #3254 · patternfly/patternfly-react · GitHub

PF4: fix(README.md): provides URL location of workspace - #3254

Merged
seanforyou23 merged 2 commits into
patternfly:masterfrom
jenny-s51:iss3154
Nov 6, 2019
Merged

PF4: fix(README.md): provides URL location of workspace #3254
seanforyou23 merged 2 commits into
patternfly:masterfrom
jenny-s51:iss3154

Conversation

jenny-s51 commented Nov 1, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

Temporary fix for #3154 (comment)

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3254.surge.sh

codecov-io commented Nov 1, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3254 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3254   +/-   ##
=======================================
  Coverage   67.43%   67.43%           
=======================================
  Files         892      892           
  Lines       24869    24869           
  Branches     2140     2140           
=======================================
  Hits        16770    16770           
  Misses       7094     7094           
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be35f9...0982d08. Read the comment docs.

boaz0 previously approved these changes Nov 4, 2019

boaz0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for doing this! I left a couple of questions/suggestions.

Copy link
Copy Markdown
Contributor Author

@seanforyou23 Thank you for your helpful feedback Michael! I've updated the README according to your suggestions.

jenny-s51 changed the title PF4: fix(README.md): adds link to localhost:8000 PF4: fix(README.md): provides URL location of workspace Nov 4, 2019
```

Go to localhost:8000.

dlabrecq Nov 5, 2019
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Although adding more info to the README is a good thing, this does not appear to address the original issue? That is, the yarn start:dev command no longer confirms exactly where the app is running.

This also does not account for the example app running on a different port, should port 8000 already be occupied.

jenny-s51 Nov 5, 2019
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@dlabrecq Thank you for your feedback Dan! This has to do with something Zack addressed here: #3154 (comment) and I added that line based on what was agreed upon in this comment. But I see what you mean -- this PR won't necessarily close that issue.

Good point about the different port -- do you happen to know what port the app runs on if localhost:8000 is already occupied?

seanforyou23 Nov 5, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@jenny-s51 if the port is already in use it prints to the console @patternfly/react-docs: Something is already running at port 8000. I think it used to be the case that an interactive console would take over and allow you to specify a different port, then proceed to launch the dev server using that new config. It seems to have regressed or been removed at some point.

I'm personally ok with pulling these changes in, but I agree it doesn't really fix the root cause. So, as long as we can leave the related issue open for future fixes we should be ok. @dlabrecq does this sound ok to you?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok, can leave that issue opened

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

seanforyou23 merged commit 482dafe into patternfly:master Nov 6, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.10
  • @patternfly/react-core@3.120.7
  • @patternfly/react-docs@4.16.15
  • @patternfly/react-inline-edit-extension@2.12.21
  • demo-app-ts@3.9.10
  • @patternfly/react-table@2.24.21
  • @patternfly/react-topology@2.11.7
  • @patternfly/react-virtualized-extension@1.3.20

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL