FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(repo): update github templates by redallen · Pull Request #3261 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(repo): update github templates - #3261

Merged
dlabaj merged 2 commits into
patternfly:masterfrom
redallen:chore/github-templates
Nov 13, 2019
ConversationCommits (2)ChecksFiles changed
Merged

chore(repo): update github templates#3261
dlabaj merged 2 commits into
patternfly:masterfrom
redallen:chore/github-templates

Conversation

redallen commented Nov 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Closes #2952

Additional issues: I did change some of the text of these templates to make them consistent.

  1. I removed the long first block comment in PULL_REQUEST_TEMPLATE.md and the <!-- feel free to add additional comments --> to stay consistent with our new ISSUE_TEMPLATE.md.
  2. I changed our ISSUE_TEMPLATE.md to use bold text for it's questions rather than headers like #### to be consistent with our PULL_REQUEST_TEMPLATE.md.
  3. In order to close Add PR check for associated issue #2952, I changed the first question in PULL_REQUEST_TEMPLATE.md to
<!-- What changes are being made? Please link the issue being addressed. -->
**What**: Closes #

from

<!-- What changes are being made? (What issue is being addressed here?) -->

**What**:

The extra line breaks are unnecessary and we should ask that they link an issue per #2952.

codecov-io commented Nov 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3261 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3261   +/-   ##
=======================================
  Coverage   67.43%   67.43%           
=======================================
  Files         892      892           
  Lines       24869    24869           
  Branches     2140     2140           
=======================================
  Hits        16770    16770           
  Misses       7094     7094           
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <ø> (ø) ⬆️
#patternfly4 64.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8ea98...cd1c40e. Read the comment docs.

patternfly-build commented Nov 4, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3261.surge.sh

tlabaj self-assigned this Nov 5, 2019
tlabaj requested a review from dlabaj November 5, 2019 17:47
dlabrecq approved these changes Nov 5, 2019
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

boaz0 reviewed Nov 6, 2019
View reviewed changes

boaz0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

dlabaj merged commit 093458b into patternfly:master Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+2 more reviewers
boaz0 boaz0 left review comments
dlabrecq dlabrecq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tlabaj

Labels

Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add PR check for associated issue

7 participants

Back | FazBrowse Home | New Git URL