FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(nav & pagelayout): removes basic nav example, switches to default variant, updates PF masthead logo by jenny-s51 · Pull Request #3262 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(nav & pagelayout): removes basic nav example, switches to default variant, updates PF masthead logo - #3262

Merged
tlabaj merged 12 commits into
patternfly:masterfrom
jenny-s51:iss3044
Dec 2, 2019
ConversationCommits (12)ChecksFiles changed
Merged

fix(nav & pagelayout): removes basic nav example, switches to default variant, updates PF masthead logo#3262
tlabaj merged 12 commits into
patternfly:masterfrom
jenny-s51:iss3044

Conversation

jenny-s51 commented Nov 5, 2019

Copy link
Copy Markdown
Contributor

Closes #3044

codecov-io commented Nov 5, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@2415a94). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3262   +/-   ##
=========================================
  Coverage          ?   67.44%           
=========================================
  Files             ?      892           
  Lines             ?    24873           
  Branches          ?     2141           
=========================================
  Hits              ?    16775           
  Misses            ?     7093           
  Partials          ?     1005
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.77% <ø> (?)
Impacted Files Coverage Δ
...rnfly-4/react-core/src/components/Nav/NavGroup.tsx 72.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2415a94...55ef878. Read the comment docs.

patternfly-build commented Nov 5, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3262.surge.sh

tlabaj requested review from jschuler and mcoker November 5, 2019 17:50
tlabaj requested a review from jessiehuff November 5, 2019 17:50
tlabaj added PF4 labels Nov 5, 2019
dlabrecq previously approved these changes Nov 5, 2019
View reviewed changes
Comment thread .circleci/index.html
</div>
<a class="pf-c-page__header-brand-link" href="#">
<img class="pf-c-brand pf-m-sm" src="https://pf4.patternfly.org/assets/images/l_pf-reverse-164x11.png" alt="Patternfly Logo" />
<img class="pf-c-brand pf-m-sm" src="https://pf4.patternfly.org/assets/images/PF-Masthead-Logo.svg" alt="Patternfly Logo" />

dlabrecq Nov 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Curious how this image is being used? I don't see it in the live page source

jenny-s51 Nov 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@dlabrecq This is how the new logo is used when I open .circleci/index.html in my browser:

jenny-s51 requested review from boaz0 and dlabrecq November 8, 2019 19:53

mcoker commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

Hey @jenny-s51 looks great! I missed one spot in the original issue - on https://patternfly-react-pr-3262.surge.sh/patternfly-4/documentation/react/demos/pagelayout, we need to remove the first (basic nav) example

redallen previously approved these changes Nov 18, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Nav/NavGroup.tsx
{title}
</h2>
<ul className={css(styles.navSimpleList)}>{children}</ul>
<ul className={css(styles.navList)}>{children}</ul>

redallen Nov 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This matches what's in Core on https://pf4.patternfly.org/documentation/core/components/nav .

mcoker previously approved these changes Nov 18, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🥇

tlabaj suggested changes Nov 19, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you move the default example above the Grouped example please.

redallen previously approved these changes Nov 21, 2019
View reviewed changes
tlabaj previously approved these changes Nov 21, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

kmcfaul previously approved these changes Nov 21, 2019
View reviewed changes

mcoker commented Nov 21, 2019

Copy link
Copy Markdown
Contributor

@jenny-s51 sorry I missed one spot - can you also update the legacy/light nav page demo to use the default nav instead of the simple nav?

jenny-s51 dismissed stale reviews from kmcfaul, tlabaj, and redallen via 55ef878 November 22, 2019 16:58
mcoker approved these changes Nov 22, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

tlabaj approved these changes Nov 26, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit fe707a3 into patternfly:master Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcoker mcoker approved these changes
jschuler Awaiting requested review from jschuler
jessiehuff Awaiting requested review from jessiehuff
boaz0 Awaiting requested review from boaz0
kmcfaul Awaiting requested review from kmcfaul
redallen Awaiting requested review from redallen
+2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jessiehuff

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update nav examples and demos

10 participants

Back | FazBrowse Home | New Git URL