FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(CatalogTile): Removed margin and fixed hidden text by rebeccaalpert · Pull Request #3285 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(CatalogTile): Removed margin and fixed hidden text - #3285

Merged
jcaianirh merged 1 commit into
patternfly:masterfrom
rebeccaalpert:catalogtileedits
Nov 8, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(CatalogTile): Removed margin and fixed hidden text#3285
jcaianirh merged 1 commit into
patternfly:masterfrom
rebeccaalpert:catalogtileedits

Conversation

rebeccaalpert commented Nov 7, 2019

Copy link
Copy Markdown
Member

Updated margins per design feedback and fixed hidden text bug.

patternfly-build commented Nov 7, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3285.surge.sh

codecov-io commented Nov 7, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3285 into master will increase coverage by 2.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
+ Coverage   64.78%   67.44%   +2.66%     
==========================================
  Files         481      892     +411     
  Lines       11699    24867   +13168     
  Branches     2141     2141              
==========================================
+ Hits         7579    16772    +9193     
- Misses       3116     7091    +3975     
  Partials     1004     1004
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.3% <ø> (?)
#patternfly4 64.78% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...patternfly-react/src/components/Spinner/Spinner.js 64.51% <0%> (-35.49%) ⬇️
...y-3/patternfly-react/src/components/Badge/index.js 62.5% <0%> (-20.84%) ⬇️
...-3/patternfly-react/src/components/Switch/index.js 62.5% <0%> (-20.84%) ⬇️
...patternfly-react/src/components/Toolbar/Toolbar.js 83.05% <0%> (-16.95%) ⬇️
...-3/patternfly-react/src/components/Button/index.js 88.23% <0%> (-11.77%) ⬇️
...ly-3/patternfly-react/src/components/Tabs/index.js 71.42% <0%> (-9.83%) ⬇️
...atternfly-react/src/components/Breadcrumb/index.js 72.22% <0%> (-9.03%) ⬇️
...ernfly-react/src/components/Wizard/WizardFooter.js 77.41% <0%> (-8.3%) ⬇️
...ponents/ApplicationLauncher/ApplicationLauncher.js 90.66% <0%> (-3.22%) ⬇️
...fly-3/patternfly-react/src/components/Nav/index.js 77.5% <0%> (-3.06%) ⬇️
... and 455 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3884f34...ca48b14. Read the comment docs.

jcaianirh previously approved these changes Nov 7, 2019
View reviewed changes

jcaianirh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

jcaianirh previously approved these changes Nov 7, 2019
View reviewed changes

jcaianirh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

patternfly-build commented Nov 7, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3285.surge.sh

jcaianirh approved these changes Nov 7, 2019
View reviewed changes

jcaianirh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

patternfly-build commented Nov 8, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3285.surge.sh

jcaianirh merged commit 4028a8c into patternfly:master Nov 8, 2019

patternfly-build commented Nov 8, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.15
  • @patternfly/react-docs@4.16.20

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jeff-phillips-18 jeff-phillips-18 approved these changes
+1 more reviewer
jcaianirh jcaianirh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jcaianirh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL