FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(react-catalog-view-extension): fix checbox margin on filter side panel by jcaianirh · Pull Request #3287 · patternfly/patternfly-react · GitHub

fix(react-catalog-view-extension): fix checbox margin on filter side panel - #3287

Merged
rebeccaalpert merged 1 commit into
patternfly:masterfrom
jcaianirh:fix-cbmargin-filter
Nov 7, 2019
Merged

fix(react-catalog-view-extension): fix checbox margin on filter side panel#3287
rebeccaalpert merged 1 commit into
patternfly:masterfrom
jcaianirh:fix-cbmargin-filter

Conversation

Copy link
Copy Markdown
Contributor

provide a 0px left margin for cb in filter side panel (overrides the -20px defaulted in console)

What:

Additional issues:

…panel

provide a 0px left margin for cb in filter side panel (overrides the -20px defaulted in console)

codecov-io commented Nov 7, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3287 into master will increase coverage by 2.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3287      +/-   ##
==========================================
+ Coverage   64.78%   67.44%   +2.66%     
==========================================
  Files         481      892     +411     
  Lines       11699    24867   +13168     
  Branches     2141     2141              
==========================================
+ Hits         7579    16772    +9193     
- Misses       3116     7091    +3975     
  Partials     1004     1004
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.3% <ø> (?)
#patternfly4 64.78% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...patternfly-react/src/components/Spinner/Spinner.js 64.51% <0%> (-35.49%) ⬇️
...y-3/patternfly-react/src/components/Badge/index.js 62.5% <0%> (-20.84%) ⬇️
...-3/patternfly-react/src/components/Switch/index.js 62.5% <0%> (-20.84%) ⬇️
...patternfly-react/src/components/Toolbar/Toolbar.js 83.05% <0%> (-16.95%) ⬇️
...-3/patternfly-react/src/components/Button/index.js 88.23% <0%> (-11.77%) ⬇️
...ly-3/patternfly-react/src/components/Tabs/index.js 71.42% <0%> (-9.83%) ⬇️
...atternfly-react/src/components/Breadcrumb/index.js 72.22% <0%> (-9.03%) ⬇️
...ernfly-react/src/components/Wizard/WizardFooter.js 77.41% <0%> (-8.3%) ⬇️
...ponents/ApplicationLauncher/ApplicationLauncher.js 90.66% <0%> (-3.22%) ⬇️
...fly-3/patternfly-react/src/components/Nav/index.js 77.5% <0%> (-3.06%) ⬇️
... and 455 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3884f34...7fd356f. Read the comment docs.

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3287.surge.sh

rebeccaalpert merged commit 895386b into patternfly:master Nov 7, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.14
  • @patternfly/react-docs@4.16.19

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL