| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
PatternFly-React preview: https://patternfly-react-pr-3291.surge.sh |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #3291 +/- ##
=======================================
Coverage 67.44% 67.44%
=======================================
Files 892 892
Lines 24867 24867
Branches 2141 2141
=======================================
Hits 16772 16772
Misses 7091 7091
Partials 1004 1004
Continue to review full report at Codecov.
|
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
| position: absolute; | ||
| right: 0; | ||
| width: 50%; | ||
| text-align: right; |
There was a problem hiding this comment.
Better to have:
.catalog-tile-pf-description {
.truncated {
overflow: hidden;
position: relative;
&::after {
background: linear-gradient(to right, rgba(255, 255, 255, 0), rgba(255, 255, 255, 1) 75%);
bottom: 0;
color: transparent;
content: ".";
position: absolute;
right: 0;
width: 50%;
text-align: right;
}
}
}
However, I don't believe we want this only applied when truncated is set. The idea is for this to auto truncate when necessary and the caller need not provide truncated text.
Sorry, something went wrong.
There was a problem hiding this comment.
The class is applied whenever the truncation function is called. The user doesn't have to provide truncated text.
Sorry, something went wrong.
There was a problem hiding this comment.
Updated the commit with the change.
Sorry, something went wrong.
There was a problem hiding this comment.
Why the check for isTruncated at all?
Sorry, something went wrong.
There was a problem hiding this comment.
If all the descriptions have these styles, even really short descriptions that don't need truncation get faded out. This is a due to a difference between the old card and the new card. The old card had a fixed height applied based on the amount of space the text took up, so it wasn't an issue. I didn't think it was a great idea to use the fixed height thing with PF4 card styles.
Sorry, something went wrong.
There was a problem hiding this comment.
OK, this PR is fine by me. The height issue might be a problem if applications try to show tiles with differing header text lengths (causing wrapping). In PF3, that was taken into consideration and the height allowed for the descriptive text auto adjusted for it. Something to watch out for.
Sorry, something went wrong.
Adjusted selector for gradient effect.
|
PatternFly-React preview: https://patternfly-react-pr-3291.surge.sh |
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Adjusted selector for gradient effect.