fix(DonutChart): Put back secondary title when showing percentage - #3299
Merged
tlabaj merged 1 commit intoNov 19, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3299.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #3299 +/- ##
==========================================
- Coverage 67.44% 67.44% -0.01%
==========================================
Files 892 892
Lines 24867 24868 +1
Branches 2141 2141
==========================================
Hits 16772 16772
- Misses 7091 7092 +1
Partials 1004 1004
Continue to review full report at Codecov.
|
Sorry, something went wrong.
dlabrecq
approved these changes
Nov 13, 2019
tlabaj
approved these changes
Nov 19, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a percentage-type donut chart, there used to be primary title (the percentage) and secondary title, which indicated what the percentage actually means. This secondary title is not being shown anymore. I believe it was accidentally droped in #2375
What: Add back the secondary title for percentage-type donut charts.
Issue #3323