FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Accordion): Add a prop to allow the box shadow to be removed by tlabaj · Pull Request #3309 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Accordion): Add a prop to allow the box shadow to be removed - #3309

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
tlabaj:accordion
Nov 20, 2019
ConversationCommits (1)ChecksFiles changed
Merged

feat(Accordion): Add a prop to allow the box shadow to be removed#3309
dlabaj merged 1 commit into
patternfly:masterfrom
tlabaj:accordion

Conversation

tlabaj commented Nov 18, 2019

Copy link
Copy Markdown
Contributor

What: Closes #3195

Additional issues:

tlabaj changed the title feat(Accordion): Add a prop to allow th box shadow to be removed feat(Accordion): Add a prop to allow the box shadow to be removed Nov 18, 2019

codecov-io commented Nov 18, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3309 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3309      +/-   ##
==========================================
- Coverage   67.44%   67.44%   -0.01%     
==========================================
  Files         892      892              
  Lines       24869    24871       +2     
  Branches     2141     2143       +2     
==========================================
  Hits        16774    16774              
  Misses       7090     7090              
- Partials     1005     1007       +2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.79% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
.../react-core/src/components/Accordion/Accordion.tsx 82.35% <0%> (-10.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a11090...23c141d. Read the comment docs.

patternfly-build commented Nov 18, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3309.surge.sh

jenny-s51 approved these changes Nov 18, 2019
View reviewed changes

jenny-s51 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good and works as expected 👍

mcoker approved these changes Nov 19, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! 🏆

dlabaj merged commit 02145a2 into patternfly:master Nov 20, 2019

patternfly-build commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.28
  • @patternfly/react-core@3.122.0
  • @patternfly/react-docs@4.16.34
  • @patternfly/react-inline-edit-extension@2.13.1
  • demo-app-ts@3.11.0
  • @patternfly/react-integration@3.11.0
  • @patternfly/react-table@2.24.33
  • @patternfly/react-topology@2.11.19
  • @patternfly/react-virtualized-extension@1.3.32

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
mcoker mcoker approved these changes
jessiehuff Awaiting requested review from jessiehuff
kmcfaul Awaiting requested review from kmcfaul
+1 more reviewer
jenny-s51 jenny-s51 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jessiehuff

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accordion: variation to remove box shadow

7 participants

Back | FazBrowse Home | New Git URL