FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(CatalogTile): Removed unneeded selector by rebeccaalpert · Pull Request #3331 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(CatalogTile): Removed unneeded selector - #3331

Merged
rebeccaalpert merged 1 commit into
patternfly:masterfrom
rebeccaalpert:catalogtileedits
Nov 20, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(CatalogTile): Removed unneeded selector#3331
rebeccaalpert merged 1 commit into
patternfly:masterfrom
rebeccaalpert:catalogtileedits

Conversation

rebeccaalpert commented Nov 20, 2019

Copy link
Copy Markdown
Member

Removed unneeded class that addresses a separate component for some reason.

jcaianirh approved these changes Nov 20, 2019
View reviewed changes

jcaianirh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

patternfly-build commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3331.surge.sh

codecov-io commented Nov 20, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@89f8bae). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3331   +/-   ##
=========================================
  Coverage          ?   67.44%           
=========================================
  Files             ?      892           
  Lines             ?    24874           
  Branches          ?     2141           
=========================================
  Hits              ?    16776           
  Misses            ?     7093           
  Partials          ?     1005
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.78% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f8bae...b137ad7. Read the comment docs.

rebeccaalpert merged commit 5892d50 into patternfly:master Nov 20, 2019
rebeccaalpert deleted the catalogtileedits branch November 20, 2019 21:27

patternfly-build commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.31
  • @patternfly/react-docs@4.16.37

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jeff-phillips-18 jeff-phillips-18 approved these changes
+1 more reviewer
jcaianirh jcaianirh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL