FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(catalog-view-extension): remove unused packages by jcaianirh · Pull Request #3332 · patternfly/patternfly-react · GitHub

fix(catalog-view-extension): remove unused packages - #3332

Merged
jcaianirh merged 1 commit into
patternfly:masterfrom
jcaianirh:catview-remove-unused
Nov 20, 2019
Merged

fix(catalog-view-extension): remove unused packages#3332
jcaianirh merged 1 commit into
patternfly:masterfrom
jcaianirh:catview-remove-unused

Conversation

jcaianirh commented Nov 20, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

remove unused packages from package.json

Additional issues:

remove unused packages from packages.json

codecov-io commented Nov 20, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3332 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
- Coverage   67.51%   67.37%   -0.14%     
==========================================
  Files         894      893       -1     
  Lines       25046    24957      -89     
  Branches     2157     2157              
==========================================
- Hits        16909    16815      -94     
- Misses       7130     7136       +6     
+ Partials     1007     1006       -1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.66% <ø> (-0.31%) ⬇️
Impacted Files Coverage Δ
...ternfly-4/react-core/src/layouts/Flex/FlexItem.tsx 45.45% <0%> (-27.28%) ⬇️
.../patternfly-4/react-core/src/layouts/Flex/Flex.tsx 81.81% <0%> (-18.19%) ⬇️
...ernfly-4/react-core/src/layouts/Flex/FlexUtils.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5892d50...3e59d54. Read the comment docs.

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3332.surge.sh

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jcaianirh merged commit a3fcfcc into patternfly:master Nov 20, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.32
  • @patternfly/react-docs@4.16.38

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL