FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(build): use patternfly-a11y by redallen · Pull Request #3339 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(build): use patternfly-a11y - #3339

Merged
tlabaj merged 4 commits into
patternfly:masterfrom
redallen:chore/patternfly-a11y
Dec 3, 2019
ConversationCommits (4)ChecksFiles changed
Merged

chore(build): use patternfly-a11y#3339
tlabaj merged 4 commits into
patternfly:masterfrom
redallen:chore/patternfly-a11y

Conversation

redallen commented Nov 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Use new repo https://github.com/patternfly/patternfly-a11y which can be given a list of URLs to run aXe against.

Report formats are console, JUnit XML, and JSON.

Can test for errors aXe considers incomplete (like occluded element color contrast), or exclude them with --noIncomplete. Can aggregate JUnit results by component and React/Core using --agregate.

Closes #3366.

redallen force-pushed the chore/patternfly-a11y branch from 4338533 to c8714b0 Compare November 21, 2019 20:51

patternfly-build commented Nov 21, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3339.surge.sh

codecov-io commented Nov 21, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3339 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3339   +/-   ##
=======================================
  Coverage   67.53%   67.53%           
=======================================
  Files         897      897           
  Lines       25120    25120           
  Branches     2173     2173           
=======================================
  Hits        16966    16966           
  Misses       7141     7141           
  Partials     1013     1013
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 65.04% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5016b5...600f046. Read the comment docs.

dgutride previously approved these changes Nov 21, 2019
View reviewed changes
redallen mentioned this pull request Nov 25, 2019
Merged

tlabaj commented Nov 26, 2019

Copy link
Copy Markdown
Contributor

Can you please add an issue for tracking purposes.

dlabrecq previously approved these changes Nov 30, 2019
View reviewed changes

redallen commented Dec 2, 2019

Copy link
Copy Markdown
Contributor Author

@dgutride @tlabaj @dlabrecq I fixed the merge conflict and added an associated issue.

tlabaj approved these changes Dec 3, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 3282d33 into patternfly:master Dec 3, 2019

patternfly-build commented Dec 3, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-docs@4.16.49

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
dgutride dgutride left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add accessibility testing framework

6 participants

Back | FazBrowse Home | New Git URL