FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PF3: add spacing between VncAction buttons in react-console by nicolethoen · Pull Request #3345 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

PF3: add spacing between VncAction buttons in react-console - #3345

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
nicolethoen:pf3_console_button_spacing
Dec 9, 2019
ConversationCommits (1)ChecksFiles changed
Merged

PF3: add spacing between VncAction buttons in react-console#3345
tlabaj merged 1 commit into
patternfly:masterfrom
nicolethoen:pf3_console_button_spacing

Conversation

nicolethoen commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

Addresses #3105

patternfly-build commented Nov 22, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3345.surge.sh

codecov-io commented Nov 22, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3345 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3345      +/-   ##
==========================================
- Coverage   67.52%   67.37%   -0.16%     
==========================================
  Files         896      893       -3     
  Lines       25112    24957     -155     
  Branches     2173     2157      -16     
==========================================
- Hits        16958    16815     -143     
+ Misses       7141     7136       -5     
+ Partials     1013     1006       -7
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.66% <ø> (-0.36%) ⬇️
Impacted Files Coverage Δ
...ternfly-4/react-core/src/layouts/Flex/FlexItem.tsx 45.45% <0%> (-27.28%) ⬇️
.../patternfly-4/react-core/src/layouts/Flex/Flex.tsx 81.81% <0%> (-18.19%) ⬇️
...mental/components/DataToolbar/DataToolbarGroup.tsx 93.75% <0%> (-6.25%) ⬇️
...nents/DataToolbar/DataToolbarExpandableContent.tsx 95.23% <0%> (-1.06%) ⬇️
...nfly-4/react-core/src/components/Select/Select.tsx 63.87% <0%> (-0.42%) ⬇️
...nfly-4/react-core/src/components/Button/Button.tsx 88.23% <0%> (-0.23%) ⬇️
...nfly-4/react-core/src/components/Dropdown/index.ts 100% <0%> (ø) ⬆️
...mental/components/DataToolbar/DataToolbarUtils.tsx 100% <0%> (ø) ⬆️
...3/patternfly-react/src/components/Button/Button.js 100% <0%> (ø) ⬆️
...ntal/components/DataToolbar/DataToolbarContent.tsx 100% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04575a6...3b4a6f2. Read the comment docs.

nicolethoen force-pushed the pf3_console_button_spacing branch from 728bb29 to 3b4a6f2 Compare November 22, 2019 17:47

KKoukiou commented Dec 9, 2019

Copy link
Copy Markdown
Collaborator

I tried it on cockpit - this change works, thanks.

nicolethoen changed the title [WIP] PF3: add spacing between VncAction buttons in react-console PF3: add spacing between VncAction buttons in react-console Dec 9, 2019
nicolethoen requested a review from tlabaj December 9, 2019 14:30
tlabaj approved these changes Dec 9, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit fdb27c8 into patternfly:master Dec 9, 2019

patternfly-build commented Dec 9, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-console@2.0.6

Thanks for your contribution! 🎉

nicolethoen deleted the pf3_console_button_spacing branch February 8, 2023 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL