FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add various table state demos by nicolethoen · Pull Request #3352 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Add various table state demos - #3352

Merged
dlabaj merged 2 commits into
patternfly:masterfrom
nicolethoen:table_demos
Dec 4, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Add various table state demos#3352
dlabaj merged 2 commits into
patternfly:masterfrom
nicolethoen:table_demos

Conversation

nicolethoen commented Nov 25, 2019

Copy link
Copy Markdown
Contributor

Addresses #3330

patternfly-build commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3352.surge.sh

codecov-io commented Nov 25, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3352 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3352   +/-   ##
=======================================
  Coverage   67.52%   67.52%           
=======================================
  Files         896      896           
  Lines       25112    25112           
  Branches     2173     2173           
=======================================
  Hits        16958    16958           
  Misses       7141     7141           
  Partials     1013     1013
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 65.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78bd323...f613acf. Read the comment docs.

mcarrano previously approved these changes Nov 25, 2019
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These look great @nicolethoen . I'm just wondering about the naming of this demo. Would "Table empty states" be more descriptive? @rachael-phillips what do you think?

dlabrecq previously approved these changes Nov 30, 2019
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good. Thanks for adding these examples

nicolethoen dismissed stale reviews from dlabrecq and mcarrano via f613acf December 2, 2019 13:37
tlabaj approved these changes Dec 4, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit 6b35f6b into patternfly:master Dec 4, 2019

patternfly-build commented Dec 4, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.43
  • @patternfly/react-core@3.125.1
  • @patternfly/react-docs@4.16.50
  • @patternfly/react-inline-edit-extension@2.14.1
  • demo-app-ts@3.13.5
  • @patternfly/react-table@2.24.45
  • @patternfly/react-topology@2.11.31
  • @patternfly/react-virtualized-extension@1.3.44

Thanks for your contribution! 🎉

nicolethoen deleted the table_demos branch February 8, 2023 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+3 more reviewers
tlabaj tlabaj approved these changes
mcarrano mcarrano left review comments
dlabrecq dlabrecq left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL