fix(table): rename visible/hiddenOn2Xl to visible/hiddenOn_2xl - #3365
Merged
tlabaj merged 1 commit intoDec 6, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3365.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #3365 +/- ##
=======================================
Coverage 67.53% 67.53%
=======================================
Files 897 897
Lines 25120 25120
Branches 2173 2173
=======================================
Hits 16966 16966
Misses 7141 7141
Partials 1013 1013
Continue to review full report at Codecov.
|
Sorry, something went wrong.
tlabaj
approved these changes
Dec 5, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
kmcfaul
approved these changes
Dec 6, 2019
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #3355
Visibility doesn't have hiddenOn2Xl and visibleOn2Xl and that's why they are set to undefined and are not shown in the class prop.
Nevertheless, these two modifiers exist according to the pf4 core documentations.
The problem is that the way react-style parses a modifier name is if it has a number, it will add _ before it. Thus, hidden-on-2xl will be hiddenOn_2xl and not hiddenOn2Xl.
This patch fixes this and adds a test to verify it works.