FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update tippy.js dependency by nicolethoen · Pull Request #3370 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Update tippy.js dependency - #3370

Merged
jschuler merged 2 commits into
patternfly:masterfrom
nicolethoen:popover_bug
Dec 5, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Update tippy.js dependency#3370
jschuler merged 2 commits into
patternfly:masterfrom
nicolethoen:popover_bug

Conversation

nicolethoen commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

Addresses: #3252

patternfly-build commented Dec 3, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3370.surge.sh

codecov-io commented Dec 3, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3370 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #3370      +/-   ##
==========================================
- Coverage   67.53%   67.52%   -0.02%     
==========================================
  Files         897      897              
  Lines       25120    25124       +4     
  Branches     2173     2173              
==========================================
  Hits        16966    16966              
- Misses       7141     7145       +4     
  Partials     1013     1013
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 65.02% <33.33%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Popover/Popover.tsx 61.01% <ø> (ø) ⬆️
...ly-4/react-core/src/components/Tooltip/Tooltip.tsx 84.74% <ø> (ø) ⬆️
.../react-core/src/helpers/PopoverBase/PopoverBase.js 65.95% <33.33%> (-1.83%) ⬇️
...patternfly-react/src/components/Tooltip/Tooltip.js 93.1% <0%> (-1.15%) ⬇️
...patternfly-react/src/components/Popover/Popover.js 31.29% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0050615...ec54cd0. Read the comment docs.

rebeccaalpert previously approved these changes Dec 3, 2019
View reviewed changes
redallen reviewed Dec 3, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Popover/Popover.tsx Outdated
zIndex?: number;
/** additional Props to pass through to tippy.js */
tippyProps?: TippyProps;
tippyProps?: object;

redallen Dec 3, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are Tippy's types no longer working? Avoiding object would be nice for consumers.

nicolethoen Dec 3, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

there are like 43 required TippyProps. So in the tests, for example, we tried only passing two tippy props, we get a type error.

redallen Dec 3, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does Partial<TippyProps> work?

redallen commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

Thanks Nicole!

tlabaj requested a review from jschuler December 5, 2019 18:24
jschuler merged commit 68c9736 into patternfly:master Dec 5, 2019
ghjm mentioned this pull request Dec 23, 2021
Closed
nicolethoen deleted the popover_bug branch February 8, 2023 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rebeccaalpert rebeccaalpert left review comments
tlabaj Awaiting requested review from tlabaj
+2 more reviewers
jschuler jschuler approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL