FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc(PageLayout): set breadcrumb, nav and title texts to sentence case by boaz0 · Pull Request #3387 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

doc(PageLayout): set breadcrumb, nav and title texts to sentence case - #3387

Merged
dlabaj merged 2 commits into
patternfly:masterfrom
boaz0:closes_3353
Dec 16, 2019
ConversationCommits (2)ChecksFiles changed
Merged

doc(PageLayout): set breadcrumb, nav and title texts to sentence case#3387
dlabaj merged 2 commits into
patternfly:masterfrom
boaz0:closes_3353

Conversation

boaz0 commented Dec 8, 2019

Copy link
Copy Markdown
Member

What: Closes #3353

doc(PageLayout): set breadcrumb, nav and title texts to sentence case
75f7939 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

patternfly-build commented Dec 8, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3387.surge.sh

codecov-io commented Dec 8, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3387 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3387   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files         897      897           
  Lines       25158    25158           
  Branches     2181     2181           
=======================================
  Hits        16980    16980           
  Misses       7162     7162           
  Partials     1016     1016
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a6eb5...f97e683. Read the comment docs.

tlabaj previously requested changes Dec 12, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The Breadcrumb component examples also needs to be updated as part of this PR.

tlabaj dismissed their stale review December 16, 2019 17:26

Made updates

tlabaj requested review from dlabaj and nicolethoen December 16, 2019 17:26
jessiehuff approved these changes Dec 16, 2019
View reviewed changes

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM :)

dlabaj merged commit f9232ef into patternfly:master Dec 16, 2019

patternfly-build commented Dec 16, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.55
  • @patternfly/react-core@3.128.1
  • @patternfly/react-docs@4.16.66
  • @patternfly/react-inline-edit-extension@2.14.15
  • demo-app-ts@3.15.1
  • @patternfly/react-table@2.24.59
  • @patternfly/react-topology@2.11.43
  • @patternfly/react-virtualized-extension@1.3.56

Thanks for your contribution! 🎉

boaz0 deleted the closes_3353 branch December 17, 2019 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
nicolethoen Awaiting requested review from nicolethoen
+2 more reviewers
jessiehuff jessiehuff approved these changes
tlabaj tlabaj left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Breadcrumbs capitalization - sentence case

6 participants

Back | FazBrowse Home | New Git URL