FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Broken Katacoda tutorial links by dlabrecq · Pull Request #3408 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Broken Katacoda tutorial links - #3408

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:3407-katacoda
Dec 17, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Broken Katacoda tutorial links#3408
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:3407-katacoda

Conversation

dlabrecq commented Dec 16, 2019 •
edited by tlabaj
Loading

Copy link
Copy Markdown
Member

The Katacoda chart tutorials have moved to a new directory. Thus, the links in the chart examples are broken.

This:
https://katacoda.com/patternfly/courses/charts/area-chart

Should be:
https://katacoda.com/patternfly/courses/react-charts/area-chart
fixes #3407

dlabrecq changed the title Broken Katacoda tutorials links Broken Katacoda tutorial links Dec 16, 2019

patternfly-build commented Dec 16, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3408.surge.sh

codecov-io commented Dec 16, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3408 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3408   +/-   ##
=======================================
  Coverage   67.44%   67.44%           
=======================================
  Files         897      897           
  Lines       25173    25173           
  Branches     2190     2190           
=======================================
  Hits        16979    16979           
  Misses       7170     7170           
  Partials     1024     1024
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.86% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3249fe0...2e60708. Read the comment docs.

christiemolloy commented Dec 16, 2019

Copy link
Copy Markdown
Member

Alternatively, we could link to the training modules on the website which will be added in this release: patternfly/patternfly-org#1586

https://www.patternfly.org/v4/documentation/core/overview/training

redallen approved these changes Dec 16, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We're adding a whole Katacoda section to the site with the next release thanks to @christiemolloy ! Maybe we can include a charts section under there in the future.

tlabaj approved these changes Dec 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit e6e72cd into patternfly:master Dec 17, 2019

patternfly-build commented Dec 17, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@5.2.8
  • @patternfly/react-docs@4.16.70

Thanks for your contribution! 🎉

dlabrecq deleted the 3407-katacoda branch January 15, 2020 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicolethoen nicolethoen approved these changes
+3 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
ddonahue007 ddonahue007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Charts: broken katacoda tutorial links

8 participants

Back | FazBrowse Home | New Git URL