[PF3] Update CustomModalDialog to match changes to original react-bootstrap ModalDialog - #3409
Merged
dlabaj merged 1 commit intoDec 16, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…tstrap ModalDialog
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3409.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #3409 +/- ##
==========================================
+ Coverage 67.12% 67.45% +0.32%
==========================================
Files 903 897 -6
Lines 25445 25170 -275
Branches 2243 2190 -53
==========================================
- Hits 17080 16978 -102
+ Misses 7334 7168 -166
+ Partials 1031 1024 -7
Continue to review full report at Codecov.
|
Sorry, something went wrong.
tlabaj
approved these changes
Dec 16, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
dlabaj
approved these changes
Dec 16, 2019
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #3364
As detailed in my comment here, since upgrading react-bootstrap in #3249 we have had a warning appear when rendering a <Modal>. This is happening because we created CustomModalDialog based on the react-bootstrap ModalDialog in order to introduce a custom prop, and react-bootstrap has since made a change requiring updates to their original ModalDialog.
Our CustomModalDialog was introduced in 9b0f3d9 (Nov 13, 2017). Looking at the history of react-bootstrap's original ModalDialog, we can see that the only real (non-code-style) change they made since we copied it was this one which introduces the onMouseDownDialog prop. This PR simply replicates that change in our CustomModalDialog.
Additional issues: This should also unblock the resolution of ManageIQ/manageiq-v2v#1037
cc @LaViro @martinpovolny @himdel