FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(DataToolbar): add and remove some modifiers to match core by nicolethoen · Pull Request #3422 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(DataToolbar): add and remove some modifiers to match core - #3422

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
nicolethoen:toolbar_bugs
Jan 13, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(DataToolbar): add and remove some modifiers to match core#3422
tlabaj merged 1 commit into
patternfly:masterfrom
nicolethoen:toolbar_bugs

Conversation

nicolethoen commented Dec 17, 2019

Copy link
Copy Markdown
Contributor

Addresses #3396

patternfly-build commented Dec 17, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3422.surge.sh

codecov-io commented Dec 17, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3422 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3422      +/-   ##
=========================================
+ Coverage    67.1%   67.1%   +<.01%     
=========================================
  Files         903     903              
  Lines       25482   25483       +1     
  Branches     2254    2254              
=========================================
+ Hits        17099   17100       +1     
  Misses       7342    7342              
  Partials     1041    1041
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...onents/DataToolbar/DataToolbarChipGroupContent.tsx 81.81% <100%> (ø) ⬆️
...fly-3/patternfly-react/src/components/Tabs/Tabs.js 33.33% <0%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d997c7e...e4b8d6f. Read the comment docs.

tlabaj previously approved these changes Jan 6, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jenny-s51 previously approved these changes Jan 8, 2020
View reviewed changes

jenny-s51 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nice! working as expected 👍

nicolethoen dismissed stale reviews from jenny-s51 and tlabaj via e4b8d6f January 9, 2020 18:18
mattnolting approved these changes Jan 9, 2020
View reviewed changes

mattnolting left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great!

tlabaj approved these changes Jan 13, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 034c041 into patternfly:master Jan 13, 2020
nicolethoen deleted the toolbar_bugs branch February 8, 2023 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mattnolting mattnolting approved these changes
+2 more reviewers
jenny-s51 jenny-s51 approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL