FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(patternfly-4/react-docs/.../icons.js): Added a link to icons docs by MariaAga · Pull Request #3430 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

docs(patternfly-4/react-docs/.../icons.js): Added a link to icons docs - #3430

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
MariaAga:documentation/add-icons-link
Jan 7, 2020
ConversationCommits (1)ChecksFiles changed
Merged

docs(patternfly-4/react-docs/.../icons.js): Added a link to icons docs#3430
tlabaj merged 1 commit into
patternfly:masterfrom
MariaAga:documentation/add-icons-link

Conversation

MariaAga commented Dec 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added a link in the react docs icon page to react-icons docs as it is unclear how to use the icons that are shown.
And fixed the link in the react icons docs
Fixes #3459

patternfly-build commented Dec 18, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3430.surge.sh

codecov-io commented Dec 18, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3430 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3430   +/-   ##
=======================================
  Coverage   67.11%   67.11%           
=======================================
  Files         903      903           
  Lines       25469    25469           
  Branches     2247     2247           
=======================================
  Hits        17093    17093           
  Misses       7342     7342           
  Partials     1034     1034
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d5dc1...bbbed52. Read the comment docs.

redallen approved these changes Dec 18, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! Welcome back to patternfly-react :)

tlabaj suggested changes Jan 6, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for adding this. Can you please link an issue for tracking.

MariaAga requested a review from tlabaj January 7, 2020 12:44
tlabaj approved these changes Jan 7, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 1b6b564 into patternfly:master Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No instructions on how to use icons in docs

5 participants

Back | FazBrowse Home | New Git URL