FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(DataList): Revert React.Component back to React.FunctionComponent by nicolethoen · Pull Request #3431 · patternfly/patternfly-react · GitHub

fix(DataList): Revert React.Component back to React.FunctionComponent - #3431

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
nicolethoen:fix_dataList
Dec 19, 2019
Merged

fix(DataList): Revert React.Component back to React.FunctionComponent#3431
dlabaj merged 1 commit into
patternfly:masterfrom
nicolethoen:fix_dataList

Conversation

Copy link
Copy Markdown
Contributor

Fixes the breaking change causing OpenShift build to fail

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3431.surge.sh

codecov-io commented Dec 19, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3431 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #3431      +/-   ##
==========================================
- Coverage   67.11%   67.09%   -0.02%     
==========================================
  Files         903      903              
  Lines       25469    25470       +1     
  Branches     2247     2251       +4     
==========================================
- Hits        17093    17090       -3     
  Misses       7342     7342              
- Partials     1034     1038       +4
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.2% <50%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...eact-core/src/components/DataList/DataListItem.tsx 53.33% <44%> (-3.34%) ⬇️
...-4/react-core/src/components/DataList/DataList.tsx 75% <63.63%> (-18.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729f5d3...a7b58b7. Read the comment docs.

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit 90f6b30 into patternfly:master Dec 19, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.59
  • @patternfly/react-core@3.129.2
  • @patternfly/react-docs@4.16.72
  • @patternfly/react-inline-edit-extension@2.14.19
  • demo-app-ts@3.16.2
  • @patternfly/react-table@2.24.63
  • @patternfly/react-topology@2.11.47
  • @patternfly/react-virtualized-extension@1.3.60

Thanks for your contribution! 🎉

nicolethoen deleted the fix_dataList branch February 8, 2023 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL