FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Page: add ability to customize screen reader label by jessiehuff · Pull Request #3433 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Page: add ability to customize screen reader label - #3433

Merged
dlabaj merged 5 commits into
patternfly:masterfrom
jessiehuff:main-label
Jan 8, 2020
ConversationCommits (5)ChecksFiles changed
Merged

Page: add ability to customize screen reader label#3433
dlabaj merged 5 commits into
patternfly:masterfrom
jessiehuff:main-label

Conversation

jessiehuff commented Dec 19, 2019

Copy link
Copy Markdown
Contributor

What: Closes #3432

Additional issues:
Similar to patternfly/patternfly#2079

patternfly-build commented Jan 6, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3433.surge.sh

codecov-io commented Jan 7, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3433 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3433      +/-   ##
=========================================
+ Coverage    67.1%   67.1%   +<.01%     
=========================================
  Files         903     903              
  Lines       25471   25472       +1     
  Branches     2251    2251              
=========================================
+ Hits        17092   17093       +1     
  Misses       7342    7342              
  Partials     1037    1037
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...tternfly-4/react-core/src/components/Page/Page.tsx 83.05% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d1221...b32ed4e. Read the comment docs.

tlabaj suggested changes Jan 7, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add this to prop to the demo-app please.

tlabaj approved these changes Jan 7, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit 4fd839c into patternfly:master Jan 8, 2020

patternfly-build commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.62
  • @patternfly/react-core@3.129.5
  • @patternfly/react-docs@4.16.75
  • @patternfly/react-inline-edit-extension@2.14.22
  • demo-app-ts@3.16.5
  • @patternfly/react-integration@3.16.1
  • @patternfly/react-table@2.24.66
  • @patternfly/react-topology@2.11.50
  • @patternfly/react-virtualized-extension@1.3.63

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+1 more reviewer
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A11y

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Page: add ability to customize screen reader label

5 participants

Back | FazBrowse Home | New Git URL