FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(DataList): remove hook by nicolethoen · Pull Request #3434 · patternfly/patternfly-react · GitHub

fix(DataList): remove hook - #3434

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
nicolethoen:fix_dataList_again
Dec 19, 2019
Merged

fix(DataList): remove hook#3434
dlabaj merged 1 commit into
patternfly:masterfrom
nicolethoen:fix_dataList_again

Conversation

Copy link
Copy Markdown
Contributor

Remove hook so Integrately can use DataList updates.

nicolethoen requested review from dlabaj and tlabaj December 19, 2019 19:22

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3434.surge.sh

codecov-io commented Dec 19, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3434 into master will increase coverage by <.01%.
The diff coverage is 44%.

@@            Coverage Diff             @@
##           master    #3434      +/-   ##
==========================================
+ Coverage   67.09%   67.09%   +<.01%     
==========================================
  Files         903      903              
  Lines       25470    25471       +1     
  Branches     2251     2251              
==========================================
+ Hits        17090    17091       +1     
  Misses       7342     7342              
  Partials     1038     1038
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.2% <44%> (ø) ⬆️
Impacted Files Coverage Δ
...eact-core/src/components/DataList/DataListItem.tsx 54.83% <44%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b1a64...e266d4b. Read the comment docs.

dlabaj merged commit 2a33ab2 into patternfly:master Dec 19, 2019
nicolethoen deleted the fix_dataList_again branch February 8, 2023 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL