FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(clipboardcopy): set type of copy and toggle buttons to 'button' by boaz0 · Pull Request #3444 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(clipboardcopy): set type of copy and toggle buttons to 'button' - #3444

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3443
Jan 7, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(clipboardcopy): set type of copy and toggle buttons to 'button'#3444
dlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3443

Conversation

boaz0 commented Jan 1, 2020

Copy link
Copy Markdown
Member

What: Closes #3443

//cc @elad661

patternfly-build commented Jan 1, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3444.surge.sh

boaz0 commented Jan 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI failure is irrelevant. Opened a new issue #3445 to follow up on this failure.

tlabaj commented Jan 6, 2020

Copy link
Copy Markdown
Contributor

Can you rebase this pr please.

fix(clipboardcopy): set type of copy and toggle buttons to 'button'
997298d 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

boaz0 commented Jan 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Done & happy new year. ❇️ 🎉 👏

codecov-io commented Jan 6, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3444 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3444   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files         903      903           
  Lines       25471    25471           
  Branches     2251     2251           
=======================================
  Hits        17091    17091           
  Misses       7342     7342           
  Partials     1038     1038
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.2% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...c/components/ClipboardCopy/ClipboardCopyButton.tsx 66.66% <ø> (ø) ⬆️
...c/components/ClipboardCopy/ClipboardCopyToggle.tsx 84.61% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88fae5...997298d. Read the comment docs.

tlabaj requested a review from mcoker January 6, 2020 18:51
tlabaj approved these changes Jan 6, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mcoker approved these changes Jan 6, 2020
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍⭐️

mcoker mentioned this pull request Jan 6, 2020
Closed
dlabaj merged commit e15d44a into patternfly:master Jan 7, 2020
tlabaj added this to the Prioritized Backlog milestone Jan 8, 2020
boaz0 deleted the closes_3443 branch January 9, 2020 07:56
tlabaj removed this from the Prioritized Backlog milestone May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
mcoker mcoker approved these changes
+1 more reviewer
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

boaz0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ClipboardCopy unusable in forms

6 participants

Back | FazBrowse Home | New Git URL