FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(DataList): properly assign selectable and selected classes by Hyperkid123 · Pull Request #3447 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(DataList): properly assign selectable and selected classes - #3447

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
Hyperkid123:fix-selectable
Jan 7, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(DataList): properly assign selectable and selected classes#3447
tlabaj merged 1 commit into
patternfly:masterfrom
Hyperkid123:fix-selectable

Conversation

Hyperkid123 commented Jan 2, 2020

Copy link
Copy Markdown
Contributor

Closes #3446

Changes

  • removed default prop of onSelectDataListItem
    • isSelectable was always true
  • added check to selectedDataListItemId
    • was always true which cause styles.modifiers.selected to be always assigned

patternfly-build commented Jan 2, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3447.surge.sh

nicolethoen previously approved these changes Jan 2, 2020
View reviewed changes
boaz0 previously approved these changes Jan 2, 2020
View reviewed changes
tlabaj previously approved these changes Jan 6, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Hyperkid123 commented Jan 7, 2020

Copy link
Copy Markdown
Contributor Author

Does anybody know if the PF3 snapshot was fixed? Or can this be merged anyway without rebasing?

boaz0 commented Jan 7, 2020

Copy link
Copy Markdown
Member

@Hyperkid123 it was fixed. 👍
Rebase and push the updates.

Hyperkid123 dismissed stale reviews from tlabaj, boaz0, and nicolethoen via 6c3ba79 January 7, 2020 08:51

codecov-io commented Jan 7, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3447 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master   #3447      +/-   ##
=========================================
+ Coverage   67.09%   67.1%   +<.01%     
=========================================
  Files         903     903              
  Lines       25471   25471              
  Branches     2251    2251              
=========================================
+ Hits        17091   17092       +1     
  Misses       7342    7342              
+ Partials     1038    1037       -1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <50%> (ø) ⬆️
Impacted Files Coverage Δ
...eact-core/src/components/DataList/DataListItem.tsx 54.83% <0%> (ø) ⬆️
...-4/react-core/src/components/DataList/DataList.tsx 81.25% <100%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88fae5...6c3ba79. Read the comment docs.

Hyperkid123 requested a review from boaz0 January 7, 2020 09:08
boaz0 approved these changes Jan 7, 2020
View reviewed changes

boaz0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

Good job @Hyperkid123

tlabaj approved these changes Jan 7, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 1784176 into patternfly:master Jan 7, 2020

patternfly-build commented Jan 7, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.61
  • @patternfly/react-core@3.129.4
  • @patternfly/react-docs@4.16.74
  • @patternfly/react-inline-edit-extension@2.14.21
  • demo-app-ts@3.16.4
  • @patternfly/react-table@2.24.65
  • @patternfly/react-topology@2.11.49
  • @patternfly/react-virtualized-extension@1.3.62
  • @patternfly/react-icons@3.14.29

Thanks for your contribution! 🎉

Hyperkid123 deleted the fix-selectable branch January 7, 2020 16:38
srambach mentioned this pull request Jan 30, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicolethoen nicolethoen approved these changes
jschuler Awaiting requested review from jschuler
kmcfaul Awaiting requested review from kmcfaul
redallen Awaiting requested review from redallen
+3 more reviewers
boaz0 boaz0 approved these changes
karelhala karelhala approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF4 DataList selectable and selected styles

7 participants

Back | FazBrowse Home | New Git URL