FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use direct paths to react-icons in prod build by Hyperkid123 · Pull Request #3448 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Use direct paths to react-icons in prod build #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evwilkin merged 1 commit into from
Jan 9, 2020
Conversation 8 Commits 1 Checks 0 Files changed
Merged

Use direct paths to react-icons in prod build #3448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .js  (1) .json  (1) dotfile  (1) All 3 file types selected
Only manifest files
Deleted files Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
3 changes: 0 additions & 3 deletions packages/patternfly-4/react-core/.babelrc
Show comments
View file
Open in desktop

This file was deleted.

31 changes: 31 additions & 0 deletions packages/patternfly-4/react-core/babel.config.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
const envDistMapping = {
cjs: 'js',
esm: 'esm',
umd: 'umd'
}

const createIconsTransformPlugin = (env) => [
"transform-imports",
{
"@patternfly/react-icons": {
transform: (importName, matches) =>
`@patternfly/react-icons/dist/${envDistMapping[env]}/icons/${importName.split(/(?=[A-Z])/).join('-').toLowerCase()}`,
preventFullImport: true
}
}
]

module.exports = {
extends: '../.babelrc',
env: {
cjs: {
plugins: [createIconsTransformPlugin('cjs')]
},
esm: {
plugins: [createIconsTransformPlugin('esm')]
},
umd: {
plugins: [createIconsTransformPlugin('umd')]
}
}
}
7 changes: 4 additions & 3 deletions packages/patternfly-4/react-core/package.json
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
"scripts": {
"build": "yarn build:babel && yarn build:types && node ./scripts/copyTS.js && node ./scripts/copyStyles.js",
"build:babel": "concurrently \"yarn build:babel:esm && yarn build:babel:umd\" \"yarn build:babel:cjs\"",
"build:babel:cjs": "babel --source-maps --extensions \".js,.ts,.tsx\" src --out-dir dist/js --presets=@babel/env",
"build:babel:esm": "babel --source-maps --extensions \".js,.ts,.tsx\" src --out-dir dist/esm",
"build:babel:umd": "babel --source-maps --extensions \".js\" dist/esm --out-dir dist/umd --plugins=transform-es2015-modules-umd",
"build:babel:cjs": "BABEL_ENV=cjs babel --source-maps --extensions \".js,.ts,.tsx\" src --out-dir dist/js --presets=@babel/env",
"build:babel:esm": "BABEL_ENV=esm babel --source-maps --extensions \".js,.ts,.tsx\" src --out-dir dist/esm",
"build:babel:umd": "BABEL_ENV=umd babel --source-maps --extensions \".js\" dist/esm --out-dir dist/umd --plugins=transform-es2015-modules-umd",
"build:types": "tsc -p tsconfig.gen-dts.json",
"clean": "rimraf dist",
"develop": "yarn build:babel:esm --skip-initial-build --watch --verbose"
Expand Down Expand Up @@ -62,6 +62,7 @@
"@types/react": "^16.4.0",
"@types/react-dom": "^16.4.0",
"babel-plugin-transform-es2015-modules-umd": "^6.24.1",
"babel-plugin-transform-imports": "^2.0.0",
"babel-plugin-typescript-to-proptypes": "^0.17.1",
"css": "^2.2.3",
"fs-extra": "^6.0.1",
Expand Down
Back | FazBrowse Home | New Git URL