FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(extensions): Move extensions to 'Extensions' in side nav category by boaz0 · Pull Request #3453 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

docs(extensions): Move extensions to 'Extensions' in side nav category - #3453

Merged
redallen merged 1 commit into
patternfly:masterfrom
boaz0:closes_3438
Jan 13, 2020
ConversationCommits (1)ChecksFiles changed
Merged

docs(extensions): Move extensions to 'Extensions' in side nav category#3453
redallen merged 1 commit into
patternfly:masterfrom
boaz0:closes_3438

Conversation

boaz0 commented Jan 5, 2020

Copy link
Copy Markdown
Member

What: Closes #3438

//cc @redallen

patternfly-build commented Jan 5, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3453.surge.sh

redallen previously approved these changes Jan 5, 2020
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks for the work, @boaz0 !

Unrelated PF3 Jest tests are failing due to it now being a new decade in packages/patternfly-3/patternfly-react/src/components/DateTimePicker/DateComponents/DecadeView.test.js:8:30.

boaz0 commented Jan 5, 2020

Copy link
Copy Markdown
Member Author

@redallen yes I know, I opened a PR to fix it: #3450

It was so much fun to learn about gatsby-theme-patternfly-org and gatsby.
Hope to contribute more to it.

Thanks.

docs(extensions): Move extensions to 'Extensions' in side nav category
0b9e1d2 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

codecov-io commented Jan 6, 2020

Copy link
Copy Markdown

Codecov Report

Merging #3453 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3453   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files         903      903           
  Lines       25471    25471           
  Branches     2251     2251           
=======================================
  Hits        17091    17091           
  Misses       7342     7342           
  Partials     1038     1038
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88fae5...0b9e1d2. Read the comment docs.

tlabaj added this to the Prioritized Backlog milestone Jan 8, 2020
tlabaj modified the milestones: Prioritized Backlog, 2020.01 Jan 8, 2020
tlabaj assigned boaz0 and unassigned boaz0 Jan 9, 2020
tlabaj removed this from the 2020.01 milestone Jan 9, 2020
tlabaj approved these changes Jan 13, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

LHinson commented Jan 13, 2020

Copy link
Copy Markdown
Member

looks good from a design perspective

redallen merged commit 54ad962 into patternfly:master Jan 13, 2020

patternfly-build commented Jan 13, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.71
  • @patternfly/react-docs@4.16.85
  • @patternfly/react-inline-edit-extension@2.14.31
  • @patternfly/react-virtualized-extension@1.3.72

Thanks for your contribution! 🎉

boaz0 deleted the closes_3438 branch January 13, 2020 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move extensions to "Extensions" side nav category in docs

6 participants

Back | FazBrowse Home | New Git URL