FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(ChipGroup): add closable chip-group by nicolethoen · Pull Request #3455 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(ChipGroup): add closable chip-group - #3455

Merged
jessiehuff merged 2 commits into
patternfly:masterfrom
nicolethoen:closable_chip_group
Jan 8, 2020
ConversationCommits (2)ChecksFiles changed
Merged

feat(ChipGroup): add closable chip-group#3455
jessiehuff merged 2 commits into
patternfly:masterfrom
nicolethoen:closable_chip_group

Conversation

nicolethoen commented Jan 6, 2020

Copy link
Copy Markdown
Contributor

addresses #2867

patternfly-build commented Jan 6, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3455.surge.sh

codecov-io commented Jan 6, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3455 into master will decrease coverage by <.01%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #3455      +/-   ##
==========================================
- Coverage   67.09%   67.09%   -0.01%     
==========================================
  Files         903      903              
  Lines       25471    25481      +10     
  Branches     2251     2254       +3     
==========================================
+ Hits        17091    17097       +6     
  Misses       7342     7342              
- Partials     1038     1042       +4
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.2% <60%> (-0.01%) ⬇️
Impacted Files Coverage Δ
.../src/components/ChipGroup/ChipGroupToolbarItem.tsx 60.86% <60%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88fae5...05931e6. Read the comment docs.

mcoker reviewed Jan 6, 2020
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/ChipGroup/ChipGroupToolbarItem.tsx Outdated
className = '',
isClosable = false,
onClick = (_e: React.MouseEvent) => undefined as any,
closeBtnAriaLabel = 'close chip group',

mcoker Jan 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not sure how important this is, but we typically sentence case things.

Suggested change
closeBtnAriaLabel = 'close chip group',
closeBtnAriaLabel = 'Close chip group',

mattnolting Jan 7, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@nicolethoen LGTM after update to sentence case 👍

mcoker previously approved these changes Jan 6, 2020
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, thanks @nicolethoen!!

jessiehuff previously approved these changes Jan 7, 2020
View reviewed changes

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I tested it for keyboard accessibility and in voice over, and it looks good in both. Great job, Nicole! :) LGTM!

tlabaj suggested changes Jan 7, 2020
View reviewed changes
Comment thread ...-4/react-integration/demo-app-ts/src/components/demos/ChipGroupDemo/ChipGroupToolbarDemo.tsx
<ChipGroup withToolbar>
{chipGroups.map(currentGroup => (
<ChipGroupToolbarItem
key={currentGroup.category}

tlabaj Jan 7, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would also add the closeBtnAriaLabel prop to the demo here.

mattnolting previously approved these changes Jan 7, 2020
View reviewed changes
nicolethoen dismissed stale reviews from mattnolting, jessiehuff, and mcoker via 05931e6 January 7, 2020 19:33
tlabaj added this to the Prioritized Backlog milestone Jan 8, 2020
tlabaj approved these changes Jan 8, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jessiehuff approved these changes Jan 8, 2020
View reviewed changes

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

jessiehuff merged commit a11dea1 into patternfly:master Jan 8, 2020

patternfly-build commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.64
  • @patternfly/react-core@3.130.0
  • @patternfly/react-docs@4.16.77
  • @patternfly/react-inline-edit-extension@2.14.24
  • demo-app-ts@3.17.0
  • @patternfly/react-integration@3.17.0
  • @patternfly/react-table@2.24.68
  • @patternfly/react-topology@2.11.52
  • @patternfly/react-virtualized-extension@1.3.65

Thanks for your contribution! 🎉

tlabaj removed this from the Prioritized Backlog milestone May 28, 2020
nicolethoen deleted the closable_chip_group branch February 8, 2023 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mattnolting mattnolting left review comments
mcoker mcoker left review comments
dlabaj Awaiting requested review from dlabaj
+2 more reviewers
jessiehuff jessiehuff approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL