FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(VncConsole): Added `additionalButtons` prop to VncConsole by bond95 · Pull Request #3465 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(VncConsole): Added additionalButtons prop to VncConsole - #3465

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
bond95:console-additional-buttons
Jan 13, 2020
ConversationCommits (1)ChecksFiles changed
Merged

feat(VncConsole): Added additionalButtons prop to VncConsole#3465
tlabaj merged 1 commit into
patternfly:masterfrom
bond95:console-additional-buttons

Conversation

bond95 commented Jan 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Closes #3475
Added support of additional buttons for VncConsole toolbar.

Additional issues: It needed for completely replace local version of VncConsole by patternfly version oVirt/ovirt-web-ui#1091

bond95 force-pushed the console-additional-buttons branch from 34b3e51 to de11496 Compare January 8, 2020 13:30
bond95 changed the title Added additionalButtons prop to VncConsole feat(VncConsole): Added additionalButtons prop to VncConsole Jan 8, 2020

patternfly-build commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3465.surge.sh

codecov-io commented Jan 8, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3465 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3465   +/-   ##
======================================
  Coverage    67.1%   67.1%           
======================================
  Files         903     903           
  Lines       25471   25471           
  Branches     2251    2251           
======================================
  Hits        17092   17092           
  Misses       7342    7342           
  Partials     1037    1037
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...rnfly-3/react-console/src/VncConsole/VncConsole.js 49.2% <ø> (ø) ⬆️
...rnfly-3/react-console/src/VncConsole/VncActions.js 88.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d1221...de11496. Read the comment docs.

bond95 commented Jan 8, 2020

Copy link
Copy Markdown
Contributor Author

@priley86 could you, please, take a look?

bond95 mentioned this pull request Jan 8, 2020
Merged
tlabaj reviewed Jan 8, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For tracking purposes, can please open an issue and note it in the description.

bond95 commented Jan 9, 2020

Copy link
Copy Markdown
Contributor Author

@tlabaj done.

bond95 requested a review from tlabaj January 13, 2020 11:18
tlabaj approved these changes Jan 13, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj modified the milestone: 2020.01 Jan 13, 2020
tlabaj merged commit f8488da into patternfly:master Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicolethoen nicolethoen approved these changes
+1 more reviewer
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2020.01

Development

Successfully merging this pull request may close these issues.

PF3 VncConsole: additional button in toolbar

5 participants

Back | FazBrowse Home | New Git URL