FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Lint md code blocks 3469 by ddonahue007 · Pull Request #3474 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Lint md code blocks 3469 - #3474

Merged
tlabaj merged 7 commits into
patternfly:masterfrom
ddonahue007:lint-md-code-blocks_3469
Jan 9, 2020
ConversationCommits (7)ChecksFiles changed
Merged

Lint md code blocks 3469#3474
tlabaj merged 7 commits into
patternfly:masterfrom
ddonahue007:lint-md-code-blocks_3469

Conversation

ddonahue007 commented Jan 9, 2020

Copy link
Copy Markdown
Member

linting code blocks in any markdown file. We are only producing warnings so not to break the build. (This will change) Initial rules could change as well. This is a good starting point to cleanup linting errors.

fixed all hard errors in this commit so not to break the build.

linting is run for pf4 only. It is run as part of the 'build:pf4' target. It also can be run by itself calling 'lint:md'

fix(linting): added eslint for *.md files
3a448e5 
linting all code blocks in any markdown file. We are only producing warnings so not to break the build. (This will change)

Also fixed all hard errors in this commit so not to break the build.
fix(linting): added 'dist' to ignore file.
1367ee6

patternfly-build commented Jan 9, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3474.surge.sh

dgutride suggested changes Jan 9, 2020
View reviewed changes

dgutride left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lets move the check to the circleci
- run:
name: MarkdownLint
command: yarn lint:md

Comment thread packages/patternfly-4/react-styles/README.md Outdated

codecov-io commented Jan 9, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3474 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3474   +/-   ##
======================================
  Coverage    67.1%   67.1%           
======================================
  Files         903     903           
  Lines       25483   25483           
  Branches     2254    2254           
======================================
  Hits        17100   17100           
  Misses       7342    7342           
  Partials     1041    1041
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49814a7...94d412b. Read the comment docs.

fix(linting): pr comment changes
d0c0599 
Change enclosing <div> tag to empty tag in README file
moved linting to run in circleCI
fixed 'variant' line in README file.
fix(linting): change eslint rule
ffed218 
make sure that circleCI step fails when there are 'errors'
fix(linting): moved lint:md to linting steps in circleCI
b613227
fix(linting): back to warnings
6af9fc6
tlabaj requested review from evwilkin and redallen January 9, 2020 15:55
dlabrecq approved these changes Jan 9, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread packages/patternfly-4/react-core/src/components/Dropdown/examples/Dropdown.md Outdated
evwilkin approved these changes Jan 9, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj approved these changes Jan 9, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 19a9ebb into patternfly:master Jan 9, 2020
ddonahue007 added this to the 2020.01 milestone Jan 9, 2020
ddonahue007 deleted the lint-md-code-blocks_3469 branch January 12, 2020 20:56
redallen reviewed Jan 13, 2020
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Dropdown/examples/Dropdown.md

```js noLive
/** Wrapped Link for DropdownItem list **/
<>

redallen Jan 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@ddonahue007 Is it possible to make the eslint check our JSX to ensure we use <React.Fragment> instead of <>? That would fix some of our fullscreen examples.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin approved these changes
+4 more reviewers
redallen redallen left review comments
dgutride dgutride approved these changes
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure

Projects

None yet

Milestone

2020.01

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL