FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add onFormatChange handler by jschuler · Pull Request #3477 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

add onFormatChange handler - #3477

Merged
tlabaj merged 2 commits into
patternfly:masterfrom
jschuler:pf3-bug-slider
Jan 9, 2020
ConversationCommits (2)ChecksFiles changed
Merged

add onFormatChange handler#3477
tlabaj merged 2 commits into
patternfly:masterfrom
jschuler:pf3-bug-slider

Conversation

jschuler commented Jan 9, 2020

Copy link
Copy Markdown
Contributor

What: Closes #3179

Add onFormatChange handler that returns the selected dropdown value

jschuler mentioned this pull request Jan 9, 2020
Closed

patternfly-build commented Jan 9, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3477.surge.sh

codecov-io commented Jan 9, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3477 into master will not change coverage.
The diff coverage is 50%.

@@          Coverage Diff           @@
##           master   #3477   +/-   ##
======================================
  Coverage    67.1%   67.1%           
======================================
  Files         903     903           
  Lines       25483   25483           
  Branches     2254    2254           
======================================
  Hits        17100   17100           
  Misses       7342    7342           
  Partials     1041    1041
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <50%> (ø) ⬆️
#patternfly4 64.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...3/patternfly-react/src/components/Slider/Slider.js 58.66% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8f2ff...086f55d. Read the comment docs.

dlabrecq approved these changes Jan 9, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj approved these changes Jan 9, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit e35419f into patternfly:master Jan 9, 2020

patternfly-build commented Jan 9, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • patternfly-react-extensions@3.0.8
  • patternfly-react@2.39.12
  • @patternfly/react-console@2.0.9
  • @patternfly/react-catalog-view-extension@1.1.67
  • @patternfly/react-charts@5.2.11
  • @patternfly/react-core@3.130.3
  • @patternfly/react-docs@4.16.80
  • @patternfly/react-inline-edit-extension@2.14.27
  • demo-app-ts@3.17.3
  • @patternfly/react-styled-system@3.7.17
  • @patternfly/react-styles@3.6.17
  • @patternfly/react-table@2.24.71
  • @patternfly/react-tokens@2.7.16
  • @patternfly/react-topology@2.11.55
  • @patternfly/react-virtualized-extension@1.3.68

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicolethoen nicolethoen approved these changes
+2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF3 Slider: No property available to control the value of the dropdown list

6 participants

Back | FazBrowse Home | New Git URL