FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove listing of icons while under construction by dgutride · Pull Request #3485 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Remove listing of icons while under construction - #3485

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
dgutride:removeicontext
Jan 16, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Remove listing of icons while under construction#3485
tlabaj merged 1 commit into
patternfly:masterfrom
dgutride:removeicontext

Conversation

dgutride commented Jan 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Removes listing of icons that we should not be fully supporting while the design team works out the correct approach. These were prematurely added.

Fixes: #3484

dgutride requested review from LHinson and tlabaj January 9, 2020 21:28

patternfly-build commented Jan 9, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3485.surge.sh

codecov-io commented Jan 9, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3485 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3485   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files         903      903           
  Lines       25482    25482           
  Branches     2257     2257           
=======================================
  Hits        17097    17097           
  Misses       7343     7343           
  Partials     1042     1042
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cba441...f724e79. Read the comment docs.

tlabaj approved these changes Jan 15, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mcarrano approved these changes Jan 15, 2020
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Text changes look good!

tlabaj merged commit 5a777c9 into patternfly:master Jan 16, 2020

patternfly-build commented Jan 16, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-docs@4.16.94

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicolethoen nicolethoen approved these changes
LHinson Awaiting requested review from LHinson
+3 more reviewers
mcarrano mcarrano approved these changes
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove icon listing temporarily while under construction

7 participants

Back | FazBrowse Home | New Git URL