fix(select): Add the type prop to the select toggle button - #3495
Merged
tlabaj merged 1 commit intoJan 13, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3495.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #3495 +/- ##
======================================
Coverage 67.1% 67.1%
======================================
Files 903 903
Lines 25483 25483
Branches 2254 2254
======================================
Hits 17100 17100
Misses 7342 7342
Partials 1041 1041
Continue to review full report at Codecov.
|
Sorry, something went wrong.
tlabaj
approved these changes
Jan 13, 2020
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
kmcfaul
approved these changes
Jan 13, 2020
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #3463
This is an easy fix.
I added select spec test to verify this works and there won't be regressions and updated the snapshot.