FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(PageHeader): removing redundant role="banner" attribute by jenny-s51 · Pull Request #3499 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(PageHeader): removing redundant role="banner" attribute - #3499

Merged
tlabaj merged 2 commits into
patternfly:masterfrom
jenny-s51:iss3498
Jan 15, 2020
ConversationCommits (2)ChecksFiles changed
Merged

fix(PageHeader): removing redundant role="banner" attribute#3499
tlabaj merged 2 commits into
patternfly:masterfrom
jenny-s51:iss3498

Conversation

jenny-s51 commented Jan 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #3498.

Additional issues: Addresses #2580.

patternfly-build commented Jan 13, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3499.surge.sh

jenny-s51 requested a review from tlabaj January 13, 2020 17:27

codecov-io commented Jan 13, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3499 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3499   +/-   ##
======================================
  Coverage    67.1%   67.1%           
======================================
  Files         903     903           
  Lines       25483   25483           
  Branches     2254    2254           
======================================
  Hits        17100   17100           
  Misses       7342    7342           
  Partials     1041    1041
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Page/PageHeader.tsx 54.83% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8488da...fd5177c. Read the comment docs.

This was referenced Jan 13, 2020
Closed
Merged
christiemolloy approved these changes Jan 13, 2020
View reviewed changes

christiemolloy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

tlabaj added the A11y label Jan 14, 2020
tlabaj requested a review from jessiehuff January 14, 2020 20:22

tlabaj commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

@jenny-s51 This will not close #2580 correct?

jenny-s51 commented Jan 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@tlabaj yes that's correct -- that issue involves the main attribute of Page as well. It was out of scope of this PR, but after looking into it, seems like we can just remove that attribute without running into any problems. Would you like me to do that so we can close #2580? Should be a very quick fix 🙂

tlabaj commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

@jenny-s51 Yes, can you please do that. Thanks!

jenny-s51 commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

@tlabaj yes! checking with @seanforyou23 now to see if doing that would resolve the issue in the way he hoped

seanforyou23 approved these changes Jan 14, 2020
View reviewed changes

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jessiehuff approved these changes Jan 14, 2020
View reviewed changes

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

jenny-s51 changed the title PF4 PageHeader: removing redundant role="banner" attribute fix(PageHeader): removing redundant role="banner" attribute Jan 15, 2020
tlabaj approved these changes Jan 15, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit d9452de into patternfly:master Jan 15, 2020

patternfly-build commented Jan 15, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.76
  • @patternfly/react-core@3.130.10
  • @patternfly/react-docs@4.16.93
  • @patternfly/react-inline-edit-extension@2.14.36
  • demo-app-ts@3.17.10
  • @patternfly/react-table@2.24.79
  • @patternfly/react-topology@2.11.63
  • @patternfly/react-virtualized-extension@1.3.77

Thanks for your contribution! 🎉

dlabrecq reviewed Jan 16, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jenny-s51 mentioned this pull request Jan 27, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers
dlabrecq dlabrecq left review comments
seanforyou23 seanforyou23 approved these changes
christiemolloy christiemolloy approved these changes
jessiehuff jessiehuff approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A11y

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PageHeader: role=banner attribute on <header>

8 participants

Back | FazBrowse Home | New Git URL