FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Lint md react core demo 3486 by ddonahue007 · Pull Request #3504 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Lint md react core demo 3486 - #3504

Merged
dlabrecq merged 8 commits into
patternfly:masterfrom
ddonahue007:lint-md_react-core_demo_3486
Jan 15, 2020
ConversationCommits (8)ChecksFiles changed
Merged

Lint md react core demo 3486#3504
dlabrecq merged 8 commits into
patternfly:masterfrom
ddonahue007:lint-md_react-core_demo_3486

Conversation

ddonahue007 commented Jan 14, 2020

Copy link
Copy Markdown
Member

Updated *.md files in demos and verified they were working in codesandbox as well

patternfly-build commented Jan 14, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3504.surge.sh

jschuler reviewed Jan 14, 2020
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/demos/BulkSelectTable.md Outdated

class BulkSelectTableDemo extends React.Component {
constructor(props) {
super();

jschuler Jan 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

can these be changed to super(props)?

ddonahue007 Jan 14, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done...

codecov-io commented Jan 14, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@a7c254b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3504   +/-   ##
=========================================
  Coverage          ?   67.09%           
=========================================
  Files             ?      903           
  Lines             ?    25482           
  Branches          ?     2257           
=========================================
  Hits              ?    17097           
  Misses            ?     7343           
  Partials          ?     1042
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.19% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c254b...1992446. Read the comment docs.

dlabrecq merged commit 01f606f into patternfly:master Jan 15, 2020

patternfly-build commented Jan 15, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.73
  • @patternfly/react-core@3.130.8
  • @patternfly/react-docs@4.16.87
  • @patternfly/react-inline-edit-extension@2.14.33
  • demo-app-ts@3.17.8
  • @patternfly/react-table@2.24.76
  • @patternfly/react-topology@2.11.60
  • @patternfly/react-virtualized-extension@1.3.74

Thanks for your contribution! 🎉

ddonahue007 deleted the lint-md_react-core_demo_3486 branch January 15, 2020 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jschuler jschuler approved these changes
dlabrecq dlabrecq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL