FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(datetimepicker): try using toLocaleTimeString by redallen · Pull Request #3506 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(datetimepicker): try using toLocaleTimeString - #3506

Merged
jschuler merged 3 commits into
patternfly:masterfrom
redallen:fix/pf3_timeHelpers
Jan 14, 2020
ConversationCommits (3)ChecksFiles changed
Merged

fix(datetimepicker): try using toLocaleTimeString#3506
jschuler merged 3 commits into
patternfly:masterfrom
redallen:fix/pf3_timeHelpers

Conversation

redallen commented Jan 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Closes #3507 and fixes tests on master

Additional issues:

ddonahue007 previously approved these changes Jan 14, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

patternfly-build commented Jan 14, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3506.surge.sh

ddonahue007 approved these changes Jan 14, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen commented Jan 14, 2020
View reviewed changes
Comment thread packages/patternfly-3/patternfly-react/src/components/DateTimePicker/TimeHelpers.js
const parsedTime = getDateFromTime(time);
if (Date.parse(parsedTime)) {
return parsedTime.toLocaleString(locale, options);
return parsedTime.toLocaleTimeString(locale, options);

redallen Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I could revert this to match DateTimePicker.js, but meh.

jschuler merged commit 93fc971 into patternfly:master Jan 14, 2020

codecov-io commented Jan 14, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3506 into master will increase coverage by 2.88%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3506      +/-   ##
=========================================
+ Coverage   64.21%   67.1%   +2.88%     
=========================================
  Files         492     903     +411     
  Lines       12316   25483   +13167     
  Branches     2254    2254              
=========================================
+ Hits         7909   17100    +9191     
- Misses       3366    7342    +3976     
  Partials     1041    1041
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <100%> (?)
#patternfly4 64.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...react/src/components/DateTimePicker/TimeHelpers.js 68.18% <100%> (ø)
...ct/src/components/DateTimePicker/DateTimePicker.js 53.42% <100%> (ø)
...patternfly-react/src/components/Spinner/Spinner.js 64.51% <0%> (-35.49%) ⬇️
...y-3/patternfly-react/src/components/Badge/index.js 62.5% <0%> (-20.84%) ⬇️
...-3/patternfly-react/src/components/Switch/index.js 62.5% <0%> (-20.84%) ⬇️
...patternfly-react/src/components/Toolbar/Toolbar.js 83.05% <0%> (-16.95%) ⬇️
...-3/patternfly-react/src/components/Button/index.js 88.23% <0%> (-11.77%) ⬇️
...ly-3/patternfly-react/src/components/Tabs/index.js 71.42% <0%> (-9.83%) ⬇️
...atternfly-react/src/components/Breadcrumb/index.js 72.22% <0%> (-9.03%) ⬇️
...ernfly-react/src/components/Wizard/WizardFooter.js 77.41% <0%> (-8.3%) ⬇️
... and 457 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6224c3d...e935a8f. Read the comment docs.

patternfly-build commented Jan 14, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • patternfly-react-extensions@3.0.9
  • patternfly-react@2.39.13
  • @patternfly/react-console@2.0.11
  • @patternfly/react-catalog-view-extension@1.1.72
  • @patternfly/react-core@3.130.7
  • @patternfly/react-docs@4.16.86
  • @patternfly/react-inline-edit-extension@2.14.32
  • demo-app-ts@3.17.7
  • @patternfly/react-table@2.24.75
  • @patternfly/react-topology@2.11.59
  • @patternfly/react-virtualized-extension@1.3.73

Thanks for your contribution! 🎉

dlabrecq reviewed Jan 16, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
dlabrecq dlabrecq left review comments
jschuler jschuler approved these changes
ddonahue007 ddonahue007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF3 DateTimePicker jest tests failing on master

6 participants

Back | FazBrowse Home | New Git URL