FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(linting): minor updates to VirtualizedTable examples. by ddonahue007 · Pull Request #3513 · patternfly/patternfly-react · GitHub

fix(linting): minor updates to VirtualizedTable examples. - #3513

Merged
jschuler merged 5 commits into
patternfly:masterfrom
ddonahue007:lint-md_react-virtualized-extension_3486
Jan 15, 2020
Merged

fix(linting): minor updates to VirtualizedTable examples.#3513
jschuler merged 5 commits into
patternfly:masterfrom
ddonahue007:lint-md_react-virtualized-extension_3486

Conversation

Copy link
Copy Markdown
Member

Added super(props) to constructor(s)
Added space after opening comment chars.

#3486

jschuler previously approved these changes Jan 15, 2020
jschuler previously approved these changes Jan 15, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3513.surge.sh

codecov-io commented Jan 15, 2020
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3513 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3513   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files         903      903           
  Lines       25482    25482           
  Branches     2257     2257           
=======================================
  Hits        17097    17097           
  Misses       7343     7343           
  Partials     1042     1042
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c64bc...239b8e8. Read the comment docs.

jschuler merged commit 9ad7f80 into patternfly:master Jan 15, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-docs@4.16.91
  • @patternfly/react-virtualized-extension@1.3.75

Thanks for your contribution! 🎉

ddonahue007 deleted the lint-md_react-virtualized-extension_3486 branch January 15, 2020 20:14

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL