FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(Spinner, DataToolbar, Divider, OverflowMenu): Promote Spinner, DataToolbar, Divider and OverflowMenu from experimental by tlabaj · Pull Request #3516 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(Spinner, DataToolbar, Divider, OverflowMenu): Promote Spinner, DataToolbar, Divider and OverflowMenu from experimental - #3516

Merged
dlabaj merged 12 commits into
patternfly:masterfrom
tlabaj:promote_spinner
Jan 21, 2020
ConversationCommits (12)ChecksFiles changed
Merged

chore(Spinner, DataToolbar, Divider, OverflowMenu): Promote Spinner, DataToolbar, Divider and OverflowMenu from experimental#3516
dlabaj merged 12 commits into
patternfly:masterfrom
tlabaj:promote_spinner

Conversation

tlabaj commented Jan 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

#3483 #3480 #3481 #3482

What: Closes #

Additional issues:

tlabaj requested review from dlabaj and evwilkin January 15, 2020 21:35

patternfly-build commented Jan 15, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3516.surge.sh

evwilkin commented Jan 15, 2020

Copy link
Copy Markdown
Member

@tlabaj the file changes look good to me but I don't see "Spinner" listed under the Component in the preview link - is this expected when promoting components? It does still show in Experimental, as expected.

codecov-io commented Jan 15, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3516 into master will increase coverage by 0.01%.
The diff coverage is 92.3%.

@@            Coverage Diff            @@
##           master   #3516      +/-   ##
=========================================
+ Coverage   67.09%   67.1%   +0.01%     
=========================================
  Files         903     903              
  Lines       25478   25498      +20     
  Branches     2259    2259              
=========================================
+ Hits        17095   17111      +16     
- Misses       7341    7345       +4     
  Partials     1042    1042
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.2% <92.3%> (ø) ⬆️
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Divider/Divider.tsx 92.85% <ø> (ø)
...e/src/components/OverflowMenu/OverflowMenuItem.tsx 100% <ø> (ø)
...ly-4/react-core/src/components/Spinner/Spinner.tsx 78.57% <ø> (ø)
...ct-core/src/components/DataToolbar/DataToolbar.tsx 79.24% <ø> (ø)
...rc/components/OverflowMenu/OverflowMenuContext.tsx 100% <ø> (ø)
...ckages/patternfly-4/react-core/src/helpers/util.ts 50.53% <ø> (ø) ⬆️
...rc/components/OverflowMenu/OverflowMenuControl.tsx 100% <ø> (ø)
.../src/components/OverflowMenu/OverflowMenuGroup.tsx 100% <ø> (ø)
...re/src/components/DataToolbar/DataToolbarUtils.tsx 100% <ø> (ø)
...fly-4/react-core/src/components/Tabs/TabButton.tsx 93.75% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464a8eb...668408d. Read the comment docs.

tlabaj changed the title chore(Spinner): Promote Spinner from experimental WIP: chore(Spinner): Promote Spinner from experimental Jan 15, 2020
dlabrecq suggested changes Jan 20, 2020
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/experimental/components/index.ts
export * from './Divider';
export * from '../../components/Divider';
export * from './Drawer';
export * from './Spinner';

dlabrecq Jan 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would it be possible to deprecate the spinner (e.g., for at least one milestone) from the experimental package Vs removing it immediately?

We're using the spinner in Cost Management and this change would break us. I could update while testing the next milestone, but it would give apps a little warning they must update.

dlabrecq Jan 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Never mind, I see that spinner is in the index file.

dlabrecq self-requested a review January 20, 2020 18:04
tlabaj changed the title WIP: chore(Spinner): Promote Spinner from experimental WIP: chore(Spinner): Promote Spinner, DataToolbar, Divider and OverflowMenu from experimental Jan 21, 2020
tlabaj changed the title WIP: chore(Spinner): Promote Spinner, DataToolbar, Divider and OverflowMenu from experimental chore(Spinner): Promote Spinner, DataToolbar, Divider and OverflowMenu from experimental Jan 21, 2020
tlabaj requested a review from dgutride January 21, 2020 18:37
dlabrecq previously approved these changes Jan 21, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj changed the title chore(Spinner): Promote Spinner, DataToolbar, Divider and OverflowMenu from experimental chore(Spinner, DataToolbar, Divider, OverflowMenu): Promote Spinner, DataToolbar, Divider and OverflowMenu from experimental Jan 21, 2020
dlabaj requested changes Jan 21, 2020
View reviewed changes

dlabaj left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good but you also need to remove the CSS imports from the react-docs in gatsby-browser.js.

evwilkin approved these changes Jan 21, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit 2aa19e3 into patternfly:master Jan 21, 2020
This was referenced Jan 21, 2020
Closed
Closed
Closed
Closed

patternfly-build commented Jan 21, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.81
  • @patternfly/react-core@3.131.4
  • @patternfly/react-docs@4.16.99
  • @patternfly/react-inline-edit-extension@2.14.41
  • demo-app-ts@3.17.15
  • @patternfly/react-integration@3.17.2
  • @patternfly/react-table@2.24.84
  • @patternfly/react-topology@2.11.68
  • @patternfly/react-virtualized-extension@1.3.82

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
evwilkin evwilkin approved these changes
dgutride Awaiting requested review from dgutride
+1 more reviewer
dlabrecq dlabrecq left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL