FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(icons): use absolute import paths by redallen · Pull Request #3517 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(icons): use absolute import paths - #3517

Merged
evwilkin merged 3 commits into
patternfly:masterfrom
redallen:feat/react-icons-cjs
Jan 31, 2020
ConversationCommits (3)ChecksFiles changed
Merged

feat(icons): use absolute import paths#3517
evwilkin merged 3 commits into
patternfly:masterfrom
redallen:feat/react-icons-cjs

Conversation

redallen commented Jan 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Closes #3448 , towards #3155

Additional issues:
Related: #3476

dlabrecq previously approved these changes Jan 16, 2020
View reviewed changes

dlabrecq left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This change looks fine, but may not obvious why components must use an absolute path. I assume we'll eventually add a linting rule for this? That is, so the changes are not accidentally reverted.

Edited: Seems there is an issue with CancelButton

patternfly-build commented Jan 16, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3517.surge.sh

codecov-io commented Jan 16, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3517 into master will increase coverage by 0.06%.
The diff coverage is 88.65%.

@@            Coverage Diff             @@
##           master    #3517      +/-   ##
==========================================
+ Coverage   67.11%   67.17%   +0.06%     
==========================================
  Files         903      907       +4     
  Lines       25498    25575      +77     
  Branches     2257     2267      +10     
==========================================
+ Hits        17113    17181      +68     
- Misses       7343     7353      +10     
+ Partials     1042     1041       -1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.36% <88.65%> (+0.11%) ⬆️
Impacted Files Coverage Δ
...rc/components/OverflowMenu/OverflowMenuControl.tsx 100% <ø> (ø)
...rc/components/OverflowMenu/OverflowMenuContext.tsx 100% <ø> (ø)
...on/src/components/TableTextInput/TableTextInput.js 100% <ø> (ø) ⬆️
.../src/components/OverflowMenu/OverflowMenuGroup.tsx 100% <ø> (ø)
...sion/src/components/ConfirmButton/ConfirmButton.js 100% <ø> (ø) ⬆️
...ly-4/react-core/src/components/Spinner/Spinner.tsx 78.57% <ø> (ø)
...ernfly-4/react-core/src/layouts/Flex/FlexUtils.tsx 100% <ø> (ø) ⬆️
.../react-core/src/components/Wizard/WizardToggle.tsx 59.37% <ø> (ø) ⬆️
...-4/react-core/src/components/Dropdown/Dropdown.tsx 100% <ø> (ø) ⬆️
...e/src/components/OverflowMenu/OverflowMenuItem.tsx 100% <ø> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb70ec...89a9dbb. Read the comment docs.

redallen requested review from dlabrecq and jschuler January 16, 2020 14:18
redallen mentioned this pull request Jan 16, 2020
Closed

karelhala commented Jan 16, 2020

Copy link
Copy Markdown
Contributor

@redallen I don't think this issue fixes #3449 am I right?

redallen commented Jan 16, 2020

Copy link
Copy Markdown
Contributor Author

You're right @karelhala , I meant #3448 .

redallen requested a review from evwilkin January 16, 2020 19:22

redallen commented Jan 16, 2020

Copy link
Copy Markdown
Contributor Author

@dlabrecq I talked to you offline about this, but the plan is to add a linting rule soon to catch ESM imports to @patternfly/react-icons.

evwilkin previously approved these changes Jan 16, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - thanks for making these changes

kmcfaul previously approved these changes Jan 21, 2020
View reviewed changes
dlabrecq previously approved these changes Jan 21, 2020
View reviewed changes
redallen dismissed stale reviews from dlabrecq, kmcfaul, and evwilkin via 89a9dbb January 30, 2020 15:53

redallen commented Jan 30, 2020

Copy link
Copy Markdown
Contributor Author

I fixed the merge conflicts and would love reapproval from @evwilkin @kmcfaul and @dlabrecq !

evwilkin approved these changes Jan 30, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

evwilkin merged commit 897d359 into patternfly:master Jan 31, 2020
evwilkin deleted the feat/react-icons-cjs branch January 31, 2020 15:16

patternfly-build commented Jan 31, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.3.0
  • @patternfly/react-core@3.135.0
  • @patternfly/react-docs@4.18.1
  • @patternfly/react-inline-edit-extension@2.16.0
  • demo-app-ts@3.21.0
  • @patternfly/react-integration@3.21.0
  • @patternfly/react-table@2.26.0
  • @patternfly/react-topology@2.13.0
  • @patternfly/react-virtualized-extension@1.3.96

Thanks for your contribution! 🎉

redallen mentioned this pull request Jan 31, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin approved these changes
jschuler Awaiting requested review from jschuler
kmcfaul Awaiting requested review from kmcfaul
+1 more reviewer
dlabrecq dlabrecq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL