FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Accessibility updates to alert for toast alerts by jessiehuff · Pull Request #3519 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Accessibility updates to alert for toast alerts - #3519

Merged
redallen merged 4 commits into
patternfly:masterfrom
jessiehuff:toast-alert
Jan 22, 2020
ConversationCommits (4)ChecksFiles changed
Merged

Accessibility updates to alert for toast alerts#3519
redallen merged 4 commits into
patternfly:masterfrom
jessiehuff:toast-alert

Conversation

jessiehuff commented Jan 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Closes #1421

patternfly-build commented Jan 16, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3519.surge.sh

jessiehuff mentioned this pull request Jan 20, 2020
Merged

codecov-io commented Jan 20, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@0fb0a43). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3519   +/-   ##
=========================================
  Coverage          ?   67.09%           
=========================================
  Files             ?      903           
  Lines             ?    25486           
  Branches          ?     2260           
=========================================
  Hits              ?    17100           
  Misses            ?     7344           
  Partials          ?     1042
Flag Coverage Δ
#misc 100% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.31% <100%> (?)
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Alert/Alert.tsx 82.05% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb0a43...d8ba6a7. Read the comment docs.

dlabrecq approved these changes Jan 21, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen approved these changes Jan 22, 2020
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @jessiehuff ! 🎖

redallen merged commit dc57757 into patternfly:master Jan 22, 2020

patternfly-build commented Jan 22, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.83
  • @patternfly/react-core@3.132.0
  • @patternfly/react-docs@4.16.101
  • @patternfly/react-inline-edit-extension@2.14.43
  • demo-app-ts@3.17.17
  • @patternfly/react-table@2.24.86
  • @patternfly/react-topology@2.11.70
  • @patternfly/react-virtualized-extension@1.3.84

Thanks for your contribution! 🎉

tlabaj reviewed Jan 22, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You are missing integration test and you need to add the new prop to the demo.

Comment thread packages/patternfly-4/react-core/src/components/Alert/Alert.tsx
const customClassName = css(
styles.alert,
isInline && styles.modifiers.inline,
isToast && 'pf-m-live',

tlabaj Jan 22, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why are you using the class name here instead of react-styles?

jessiehuff mentioned this pull request Jul 2, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kmcfaul kmcfaul approved these changes
seanforyou23 Awaiting requested review from seanforyou23
+3 more reviewers
tlabaj tlabaj left review comments
dlabrecq dlabrecq approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Alert: create variation to use for dynamic notifications

7 participants

Back | FazBrowse Home | New Git URL