FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(select): set a unique id to the select toggle typeahead input by boaz0 · Pull Request #3529 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(select): set a unique id to the select toggle typeahead input - #3529

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3487
Jan 22, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(select): set a unique id to the select toggle typeahead input#3529
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3487

Conversation

boaz0 commented Jan 19, 2020

Copy link
Copy Markdown
Member

What: Closes #3487

// @keithjgrant can you confirm it fixes the problem?

patternfly-build commented Jan 19, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3529.surge.sh

dlabrecq previously approved these changes Jan 20, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, but something appears to be wrong with the tests -- 7 snapshots failed.

fix(select): set a unique id to the select toggle typeahead input
f976264 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

codecov-io commented Jan 20, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3529 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3529   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files         903      903           
  Lines       25482    25482           
  Branches     2257     2257           
=======================================
  Hits        17097    17097           
  Misses       7343     7343           
  Partials     1042     1042
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.19% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx 64.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237727e...f976264. Read the comment docs.

tlabaj approved these changes Jan 22, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 40dd8f1 into patternfly:master Jan 22, 2020
boaz0 deleted the closes_3487 branch January 22, 2020 15:14

patternfly-build commented Jan 22, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.82
  • @patternfly/react-core@3.131.5
  • @patternfly/react-docs@4.16.100
  • @patternfly/react-inline-edit-extension@2.14.42
  • demo-app-ts@3.17.16
  • @patternfly/react-table@2.24.85
  • @patternfly/react-topology@2.11.69
  • @patternfly/react-virtualized-extension@1.3.83

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kmcfaul kmcfaul approved these changes
+2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF4 Select renders with hard-coded id

6 participants

Back | FazBrowse Home | New Git URL