FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

allow string literals to be used for FlexItem modifiers by jschuler · Pull Request #3544 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

allow string literals to be used for FlexItem modifiers - #3544

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
jschuler:flex-item-modifiers
Jan 22, 2020
ConversationCommits (1)ChecksFiles changed
Merged

allow string literals to be used for FlexItem modifiers#3544
tlabaj merged 1 commit into
patternfly:masterfrom
jschuler:flex-item-modifiers

Conversation

jschuler commented Jan 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

FlexItem gave TS errors when string literals were used, e.g. breakpoint: 'sm'. It was working fine when used with the enum breakpoint: FlexBreakpoints.xl

Closes: #3547

patternfly-build commented Jan 21, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3544.surge.sh

codecov-io commented Jan 21, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3544 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3544      +/-   ##
=========================================
+ Coverage   67.09%   67.1%   +<.01%     
=========================================
  Files         903     903              
  Lines       25478   25478              
  Branches     2259    2259              
=========================================
+ Hits        17095   17096       +1     
  Misses       7341    7341              
+ Partials     1042    1041       -1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/src/layouts/Flex/FlexUtils.tsx 100% <ø> (ø) ⬆️
...ternfly-4/react-core/src/layouts/Flex/FlexItem.tsx 81.81% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e940d3...cb21e6d. Read the comment docs.

tlabaj commented Jan 22, 2020

Copy link
Copy Markdown
Contributor

Is there an issue for this one?

jschuler commented Jan 22, 2020

Copy link
Copy Markdown
Contributor Author

@tlabaj no this came from slack

tlabaj approved these changes Jan 22, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit e97cc3a into patternfly:master Jan 22, 2020

patternfly-build commented Jan 22, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.84
  • @patternfly/react-core@3.132.1
  • @patternfly/react-docs@4.16.102
  • @patternfly/react-inline-edit-extension@2.14.44
  • demo-app-ts@3.17.18
  • @patternfly/react-table@2.24.87
  • @patternfly/react-topology@2.11.71
  • @patternfly/react-virtualized-extension@1.3.85

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot use string literals for FlexItem modifiers

5 participants

Back | FazBrowse Home | New Git URL