FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Table): Make IAction onClick optional by Venefilyn · Pull Request #3558 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Table): Make IAction onClick optional - #3558

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
Venefilyn:patch-1
Jan 23, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(Table): Make IAction onClick optional#3558
tlabaj merged 1 commit into
patternfly:masterfrom
Venefilyn:patch-1

Conversation

Venefilyn commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

What: Closes #3557

Additional issues:

patternfly-build commented Jan 23, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3558.surge.sh

codecov-io commented Jan 23, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3558 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3558   +/-   ##
=======================================
  Coverage   67.11%   67.11%           
=======================================
  Files         903      903           
  Lines       25502    25502           
  Branches     2262     2262           
=======================================
  Hits        17115    17115           
  Misses       7346     7346           
  Partials     1041     1041
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...rnfly-4/react-table/src/components/Table/Table.tsx 91.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327402f...f7ae114. Read the comment docs.

seanforyou23 approved these changes Jan 23, 2020
View reviewed changes

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like this fixes that console error we've had for a while Warning: Failed prop type: Invalid prop actions[1] supplied to Table. - nice work!!

tlabaj approved these changes Jan 23, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit e4671f8 into patternfly:master Jan 23, 2020
Venefilyn deleted the patch-1 branch January 23, 2020 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
seanforyou23 seanforyou23 approved these changes
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Table IAction require onClick to be supplied

7 participants

Back | FazBrowse Home | New Git URL