FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Table): Fixes issue 3559, for table we now default to a div i… by dlabaj · Pull Request #3567 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Table): Fixes issue 3559, for table we now default to a div i… - #3567

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
dlabaj:issue_3559
Jan 24, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(Table): Fixes issue 3559, for table we now default to a div i…#3567
tlabaj merged 1 commit into
patternfly:masterfrom
dlabaj:issue_3559

Conversation

dlabaj commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

This fixes the double anchor tag that was showing up in the table.

fix #3559

fix(Table fix): Fixes issue 3559, for table we now default to a div i…
ee7bb7c 
…nstead of a

This fixes the double anchor tag that was showing up in the table.

fix #3559

patternfly-build commented Jan 23, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3567.surge.sh

codecov-io commented Jan 23, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3567 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3567   +/-   ##
=======================================
  Coverage   67.11%   67.11%           
=======================================
  Files         903      903           
  Lines       25502    25502           
  Branches     2262     2262           
=======================================
  Hits        17115    17115           
  Misses       7346     7346           
  Partials     1041     1041
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...react-table/src/components/Table/ActionsColumn.tsx 76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e3c23...ee7bb7c. Read the comment docs.

dlabaj changed the title fix(Table fix): Fixes issue 3559, for table we now default to a div i… fix(Table): Fixes issue 3559, for table we now default to a div i… Jan 24, 2020
tlabaj approved these changes Jan 24, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 578950b into patternfly:master Jan 24, 2020

patternfly-build commented Jan 24, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-docs@4.17.1
  • @patternfly/react-inline-edit-extension@2.15.1
  • @patternfly/react-table@2.25.1

Thanks for your contribution! 🎉

Venefilyn commented Jan 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

By just changing to <div>, we loose the cursor pointer on normal actions. Do we need to change styling that would apply to all DropdownItems?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

karelhala Awaiting requested review from karelhala
seanforyou23 Awaiting requested review from seanforyou23
3 more reviewers
dlabrecq dlabrecq approved these changes
jenny-s51 jenny-s51 approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DropdownItem defaults to anchor component

7 participants

Back | FazBrowse Home | New Git URL