FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(alert): fix integration test regression by redallen · Pull Request #3594 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(alert): fix integration test regression - #3594

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
redallen:fix/alert-cypress
Jan 27, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(alert): fix integration test regression#3594
tlabaj merged 1 commit into
patternfly:masterfrom
redallen:fix/alert-cypress

Conversation

redallen commented Jan 27, 2020

Copy link
Copy Markdown
Contributor

What: Fixes integration tests on master

tlabaj approved these changes Jan 27, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

patternfly-build commented Jan 27, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3594.surge.sh

tlabaj merged commit 0fd41b1 into patternfly:master Jan 27, 2020

codecov-io commented Jan 27, 2020

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@5125c30). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3594   +/-   ##
=========================================
  Coverage          ?   67.15%           
=========================================
  Files             ?      907           
  Lines             ?    25559           
  Branches          ?     2267           
=========================================
  Hits              ?    17165           
  Misses            ?     7353           
  Partials          ?     1041
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.31% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5125c30...c516b84. Read the comment docs.

patternfly-build commented Jan 27, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.2.4
  • @patternfly/react-core@3.134.1
  • @patternfly/react-docs@4.17.5
  • @patternfly/react-inline-edit-extension@2.15.5
  • demo-app-ts@3.19.1
  • @patternfly/react-integration@3.19.1
  • @patternfly/react-table@2.25.5
  • @patternfly/react-topology@2.12.4
  • @patternfly/react-virtualized-extension@1.3.92

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
evwilkin Awaiting requested review from evwilkin
+2 more reviewers
jessiehuff jessiehuff approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL